Favicon unread count #267
Merged
Favicon unread count #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarebyte
reviewed
Jan 19, 2017
| @@ -31,6 +31,47 @@ function getMarkedOrCurrentRows() { | |||
| return hasMarkedRows() ? getMarkedRows() : getCurrentRow() | |||
| } | |||
|
|
|||
| function updateFavicon() { | |||
| console.log("update") | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Since we're using turbolinks and effectively refreshing the page every time, could we just embed the unread count in the page and read it from there instead of making an Ajax call? |
|
@andrew some actions does not reload page, like "mark as unread". We would still like to show the change in the favicon after this action immediately (at least I would be expecting such behaviour). |
|
Ok cool, LGTM then 👍 |
|
Thanks @karpiu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Feedback appreciated.