-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
// Get the user search results based on MetaService#URL | ||
// | ||
// https://developer.github.com/v3/meta/#meta | ||
func (m *MetaService) One() (meta Meta, result *Result) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is One
a good name for this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking. One
isn't a great fit here, is it? Wondering if we should forgo the service and just have client.Meta
return an ApiInfo
struct? Thoughts?
@pengwynn can you please provide some feedback here? We are implementing other missing pieces and would like to know if you are interested in more PRs. |
@pcasaretto @brodock: My apologies, I was on vacation when this landed. Was buried in my ⭐ folder. I left some feedback. Thanks for the patch! |
Included a draft for the tests
Thanks for the feedback @pengwynn. Tried to incorporate all of it in the most recent commit. |
) | ||
|
||
// Meta return an APIInfo with the current API meta information | ||
func (c *Client) Meta(uri *Hyperlink) (info APIInfo, result *Result) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a little confused if I should accept a *url.URL
, a *Hyperlink
, or nothing at all here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good.
I've added tests for the basic cases, but there is lack of coverage where the IPs and IPNets get parsed. |
I think this is fine for now. Thanks for the patch. 🍰 |
Hey guys,
Learning go and currently using go-octokit as a dependency for another project.
I wanted to contribute back and also scratch my own itch :) .
Opening this PR with WIP to get early feedback.
The code currently works.
Some specific questions on the code itself.
Thanks!