This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
[WIP] Refactoring Search API to accept query parameters through a map. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to exapnd the URI
| @@ -5,44 +5,44 @@ import ( | |||
| "net/url" | |||
| ) | |||
|
|
|||
| var SearchURL = Hyperlink("search{/type}?q={query}{&page,per_page,sort,order}") | |||
| var SearchURL = Hyperlink("search{/type}?q={query}&page={page}&per_page={per_page}&sort={sort}&order={order}") | |||
There was a problem hiding this comment.
No need to change these. That's the correct format for URI template params like this. The expansion will handle the ? and & automatically.
|
Please take a look. Note that only the user search has been implemented. |
|
@pengwynn Please take a look. I've refactored the code as we discussed. |
| ) | ||
|
|
||
| var SearchURL = Hyperlink("search{/type}?q={query}{&page,per_page,sort,order}") | ||
| var SearchURITemplate = "search{/type}?q={query}{&page,per_page,sort,order}" |
There was a problem hiding this comment.
I like keeping this a Hyperlink for convenience.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pengwynn Here's the barebones modification to the search API, just to check if I'm on the right track.