Respect NO_PROXY environment variable #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
approved these changes
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressing the same issue as #557, but delegates the logic to the well-tested proxy-from-env library.
I think this should be released as a patch that simply fixes an issue with the current support for environment variables.
I've also included a small fix to the tests. For some reason,
nopeon my MacOS High Sierra system resolves to one of my external IP addresses, which makes the test non-deterministic. I've changed it to attempt to connect to127.0.0.1:8which will reliably refuse a connection. Intriguingly, this is also a good test of the proxy handling.closes #557