Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing login and allow_signup parameter to OauthLoginRequest #1918

Closed
patriksvensson opened this Issue Dec 1, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@patriksvensson
Copy link
Contributor

commented Dec 1, 2018

It would be great if the (optional) login and allow_signup parameters was present on the OauthLoginRequest class.

Documentation for this can be found here: https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/#parameters

I would be happy to submit a PR for this.

@ryangribble

This comment has been minimized.

Copy link
Collaborator

commented Dec 2, 2018

Hi @patriksvensson, some of these older endpoints or requests have had fields added to them over time which we've missed in octokit!

It would be awesome if you want to send in a PR.

FYI our convention for optional fields is they should be nullable and should be set via object initialisation syntax (ie not via the ctor) if that helps! 🙏

ryangribble added a commit that referenced this issue Jan 30, 2019

Adds missing OAuth login request parameters (#1919)
* Adds support for 'login' parameter
* Adds support for 'allow_signup' parameter

Closes #1918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.