Add cancellation token support for release assets uploading #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatoStoelen
commented
Nov 2, 2020
Comment on lines
+512
to
+524
| private class CancellationTestHttpClient : IHttpClient | ||
| { | ||
| public async Task<IResponse> Send(IRequest request, CancellationToken cancellationToken) | ||
| { | ||
| await Task.Delay(TimeSpan.FromSeconds(1), cancellationToken); | ||
|
|
||
| throw new Exception("HTTP operation was not cancelled"); | ||
| } | ||
|
|
||
| public void Dispose() { } | ||
|
|
||
| public void SetRequestTimeout(TimeSpan timeout) { } | ||
| } |
There was a problem hiding this comment.
Couldn't figure out how to set this up using NSubstitute. Hence, this mock of IHttpClient.
Codecov Report
@@ Coverage Diff @@
## main #2267 +/- ##
==========================================
+ Coverage 65.97% 66.00% +0.02%
==========================================
Files 553 553
Lines 14435 14437 +2
Branches 844 844
==========================================
+ Hits 9524 9529 +5
+ Misses 4752 4749 -3
Partials 159 159
|
shiftkey
changed the title
As this is only a spike for octokit#1840, only the POST methods are targeted for now.
As this is only a spike for octokit#1840, only the POST methods are targeted for now.
Spike of octokit#1840 to enable cancellation of release asset uploading.
shiftkey
force-pushed
the
cancellation-spike-release-assets
branch
from
2ad2839
to
093a30c
Compare
shiftkey
approved these changes
Feb 21, 2021
|
release_notes: Added cancellation token support for release assets uploading API |
nickfloyd
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small spike for #1840
Added an optional cancellation token to
IReleasesClient.UploadAsset(...).To make it easier to continue this work, I did the same for all the
Postmethods inIApiConnectionandIConnectionas well.