[feat]: Adding repository variables #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nickfloyd
changed the title
nickfloyd
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Hey @michaeljolley thanks for the contributions here. My only reflection on this was about the Variable object and how it could also be represented as .NET's KeyValuePair. Implemented as is, is totally fine btw - having a concrete representation could be beneficial to serialization and the way we debug log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2753
Before the change?
No access was provided for repository variables.
After the change?
Adds the ability to:
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!