[BREAKING CHANGES]: int to long Ids for PreReceiveHook, Deployment Environments, Repository, Org Team, Repo Invitations, Public Key, Project Cards, Organization Invitation, Migrations, GpgKey, Deployment, Authorizations, Accounts / Profiles, Codespace / Workspaces #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfloyd
added
Type: Breaking change
1 task
kfcampbell
approved these changes
Jun 24, 2024
Contributor
kfcampbell
left a comment
kfcampbell
left a comment
There was a problem hiding this comment.
Awesome job! This is super helpful for our users.
nickfloyd
changed the title
nickfloyd
changed the title
kfcampbell
approved these changes
Jun 25, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2893
We have uncovered a series of issues around the IDs used across our API surface (Issues, Pull Requests, deployments, etc.. are all effected).
The GitHub database schemas were changed to accommodate for the growing IDs - migrating many of them from int to bigint - this SDK was lagging behind in those changes so when API calls began to return data that was too large for the types defined in our SDKs - their apps, integration, and automation began to break.
Before the change?
long(e.g. a release ID) but the class had this defined as anint- this would cause the SDK to throw an overflow exception.After the change?
inttypes to belongacross the SDKs - this will allow for the larger IDs to be returned without causing an overflow exception.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!