Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[WIP] #373 added more specific exception when PR is not mergeable #452

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

adamralph commented Apr 10, 2014

Marked as WIP. Re #373.

So to shed a little light: I sent this PR (somewhat hurriedly) during my talk this evening (http://www.meetup.com/Zurich-Developers-NET-User-Group/events/166898202/) as a demo of OSS contribution. Still a few things outstanding:

  • tests
  • reconsideration of the design of PullRequestNotMergeableException (I simply copied PrivateRepositoryQuotaExceededException and just made the minimum alterations to get it compiling)
  • inclusion of the new exception in the Mono, NetCore45 and Portable projects (skipped to save time)
  • XML docs for PullRequestNotMergeableException (I just ripped out the existing ones since they didn't make sense on the new type)

Have I taken the correct approach in PullRequestsClient.Merge()?

@adamralph adamralph changed the title from #373 added more specific exception when PR is not mergeable to [WIP] #373 added more specific exception when PR is not mergeable Apr 10, 2014

Contributor

adamralph commented Apr 11, 2014

Oh, and I also forgot to branch, ah well, I think the demo was useful even if the resulting PR wasn't 😉. I'll send another PR from a branch to supersede this one.

@Haacked Haacked closed this Apr 14, 2014

Owner

Haacked commented Apr 14, 2014

We await your new PR. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment