Feature/accept oauth token #12
Conversation
- Pass `login` & `oauth_token` to Client.new to authenticate request - Prioritize basic authentication over OAuth if API `token` is provided - Include basic test of authenticated request
|
I'll make sure to merge this into the rspec branch and add specs. |
|
Cool. Here's a feature branch on top of your latest from the rspec branch: I omitted the unit test in this branch. All specs passing. |
|
Thanks for adding this. Just pulled in it. |
|
Sweet; thanks for Octokit. Loving the new API (and name). A note for when you're adding tests (which you may already know): Not all things are equal between OAuth & Token Auth. Namely, user & deploy keys can't be accessed or modified by requests authenticated with OAuth. |
|
Thanks for the reminder. I think that's why I only bothered implementing basic auth in the first place, but I'm happy to have OAuth as an alternative for those who want it. |
Update specs; Add spec for closed issue, since it includes the "closed_at" field Closes octokit#12
Allows use of an OAuth access token for authenticated API requests.
Usage: Octokit::Client.new(:login => 'login', :oauth_token => 'oauth_token')
Includes one simple test. I figure these will be clobbered by the 'rspec' branch soon.