Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Octokit working with Ruby's immutable ("frozen") string literals functionality #1426

merged 4 commits into from Jun 6, 2022


Copy link

This picks up @olleolleolle's work in #1354, getting Ruby's immutable ("frozen") string literal functionality working in Octokit.rb and enforcing that in our CI setup.

The one thing that has changed since the original PR - which I have to create as I am unable to contribute to the branch - is that a new version of the dependency multipart-post gem has been released which makes it frozen string-compatible ❤️

olleolleolle and others added 4 commits June 1, 2022 19:27
If it works, then great, if not, we learned something.
In order to support --enable-frozen-literal, this change explicitly uses a mutable string - the unary plus does that.
@timrogers timrogers requested a review from nickfloyd June 5, 2022 17:38
Copy link

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@timrogers timrogers merged commit 6202e72 into 4-stable Jun 6, 2022
24 checks passed
@nickfloyd nickfloyd deleted the frozen-string-literal branch June 6, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants