Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Rubocop - the sequel #1441

Merged
merged 13 commits into from Jun 8, 2022
Merged

Enable Rubocop - the sequel #1441

merged 13 commits into from Jun 8, 2022

Commits on Jun 7, 2022

  1. Fix Rubocop configuration so Rubocop can run

    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    d4f282c View commit details
    Browse the repository at this point in the history

  2. Run Rubocop in GitHub Actions on push and PR

    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    eb635d8 View commit details
    Browse the repository at this point in the history

  3. Use Rubocop v0.81, the last version to support Ruby 2.3

    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    7485559 View commit details
    Browse the repository at this point in the history

  4. Target Rubocop to Ruby 2.3, our earliest supported Ruby version

    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    a53cb0a View commit details
    Browse the repository at this point in the history

  5. Enable new Rubocop cops that have not been turned on yet

    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    ff8dc9c View commit details
    Browse the repository at this point in the history

  6. Autocorrect Rubocop offences

    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    b2aa43f View commit details
    Browse the repository at this point in the history

  7. Revert problematic Configurable#each_key Rubocop autocorrects

    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    415c2d8 View commit details
    Browse the repository at this point in the history

  8. Disable the Layout/BlockAlignment cop for Guardfile, since it is erro… 

    …ring
    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    ab1b73f View commit details
    Browse the repository at this point in the history

  9. Generate Rubocop todo list from changes which can't be autocorrected

    @timrogers
    timrogers committed Jun 7, 2022
    Copy the full SHA
    0fa2e75 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Test against Ruby 2.3 and Ruby 2.4 in CI

    @timrogers
    timrogers committed Jun 8, 2022
    Copy the full SHA
    dc6eaeb View commit details
    Browse the repository at this point in the history

  2. Only install faraday-retry and faraday-multipart in CI when running F… 

    …araday 2.x
    @timrogers
    timrogers committed Jun 8, 2022
    Copy the full SHA
    f2a11a9 View commit details
    Browse the repository at this point in the history

  3. Update RubyGems in CI on Ruby 2.3 and 2.4, as well as 2.5

    @timrogers
    timrogers committed Jun 8, 2022
    Copy the full SHA
    64c95b4 View commit details
    Browse the repository at this point in the history

  4. Don't test with frozen string literals on Ruby 2.3 

    ERB in Ruby 2.3 doesn't seem to be frozen string literal
compatible - at least under certain cases. I observed a number
of test failures in GitHub Actions when working with templates,
generating an error like this:

```
(erb):1:in `concat': can't modify frozen String (RuntimeError)
```

You can see an example [here][1].

It seems prudent just to ignore this since (a) people are unlikely
to use Ruby 2.3, (b) we are set to drop support for it and (c)
it's even more unlikely that people use Ruby 2.3 *and* frozen
string literals.

[1]: https://github.com/octokit/octokit.rb/runs/6792298625?check_suite_focus=true
    @timrogers
    timrogers committed Jun 8, 2022
    Copy the full SHA
    fa00889 View commit details
    Browse the repository at this point in the history