Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify method signature for Pub Sub Hubbub methods #44

Merged
merged 1 commit into from Jun 30, 2011
Merged

Modify method signature for Pub Sub Hubbub methods #44

merged 1 commit into from Jun 30, 2011

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jun 30, 2011

Convert subscribe_service_hook, unsubscribe_service_hook to accept a single Repository parameter, instead of seperate user, repository parameters

See this thread

@catsby
Convert subscribe_service_hook, unsubscribe_service_hook to accept a
d11d0e6 
single `Repository` parameter, instead of seperate `user`, `repository`
parameters

See
babb695#commitcomment-454083
@sferik
Copy link
Member

sferik commented Jun 30, 2011

Love this change. Thanks, Clint.

sferik added a commit that referenced this pull request Jun 30, 2011
@sferik
Merge pull request #44 from ctshryock/pub_sub_hubbub_parameters
3576778 
Modify method signature for Pub Sub Hubbub methods
@sferik sferik merged commit 3576778 into octokit:master Jun 30, 2011
@catsby
Copy link
Contributor Author

catsby commented Jun 30, 2011

Not sure

@sferik
Copy link
Member

sferik commented Jun 30, 2011

GENUINE! ❤️

@sferik
Copy link
Member

sferik commented Jun 30, 2011

I'm a sticker for consistency in APIs, whitespace, everything...

Changes like this make me very happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@catsby @sferik @phoolish