docs(generated): fix OpenAPI spec link #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a protocol, this link is interpreted as a relative URL, so if the file is viewed at https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/master/src/generated/README.md the link resolves to https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/master/src/generated/github.com/github/rest-api-description which does not exist. This commit adds the https:// protocol so the link always resolve to https://github.com/github/rest-api-description Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
wolfy1339
added
Type: Documentation
gr2m
approved these changes
Jan 4, 2021
Contributor
|
🎉 This PR is included in version 4.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining the octokit modules, they are quite impressive!
While I was looking around, I noticed that the link to "GitHub's OpenAPI spec" in
src/generated/README.mdis dead. The cause is that, without a protocol, this link is interpreted as a relative URL. If the file is viewed at https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/master/src/generated/README.md, the link resolves to https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/master/src/generated/github.com/github/rest-api-description which does not exist. This PR addshttps://so the link resolves to https://github.com/github/rest-api-description which I assume is the original intention.Thanks,
Kevin