Update to @octokit/plugin-rest-endpoint-methods@5.0.1 #44
Description
Checklist
- I checked all open bugs and none of them matched my problem.
Environment
- https://api.github.com
- GitHub Enterprise Server:
- GitHub Enterprise Cloud
- Node.js
- Browsers:
- Others:
Versions
├─┬ @octokit/rest@18.5.2 invalid
│ ├── @octokit/core@3.4.0 extraneous
│ ├── @octokit/plugin-paginate-rest@2.13.3 extraneous
│ ├── @octokit/plugin-request-log@1.0.3 extraneous
│ └── @octokit/plugin-rest-endpoint-methods@5.0.0 extraneous
also @octokit/types@6.13.1, not sure why it’s not showing up in that output
What happened?
TypeScript builds are failing with
node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts(1801,60): error TS2339: Property 'POST /repos/{owner}/{repo}/forks{?org,organization}' does not exist on type 'Endpoints'.
node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts(1802,33): error TS2339: Property 'POST /repos/{owner}/{repo}/forks{?org,organization}' does not exist on type 'Endpoints'.
This package has a pinned dependency on @octokit/plugin-rest-endpoint-methods@5.0.0, but it transitively has a range dependency on @octokit/types. This change to @octokit/plugin-rest-endpoint-methods necessitated corresponding changes to @octokit/types. Unfortunately, the dependency is bidirectional from a typings perspective: anyone with the latest @octokit/types also needs the latest @octokit/plugin-rest-endpoint-methods for their build to succeed.
Some potential solutions:
- Update @octokit/plugin-rest-endpoint-methods to 5.0.1 in this project’s package.json
- Unpin that dependency so we can get updates to it without a new version of this package
- Pin @octokit/types to an exact version, coordinated with @octokit/plugin-rest-endpoint-methods’ version, somewhere down the dependency chain
(Note: For anyone else hitting this issue and just looking for a workaround, use "skipLibCheck": true in your tsconfig.json.)