Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump minimal version of @octokit/plugin-paginate-rest to v2.16.4 to prevent typescript compile errors #120

Merged
merged 1 commit into from Sep 30, 2021

Conversation

@webstech
Copy link
Contributor

@webstech webstech commented Sep 28, 2021

Update package "@octokit/plugin-paginate-rest" to 2.16.4. While npm can update the package, it does not always do so and Typescript gets compile errors such as:

Property 'GET /user/{username}/packages' does not exist on type 'Endpoints'.

This should address issue #115 without user intervention required.

Update package "@octokit/plugin-paginate-rest" to 2.16.4.  While
npm can update the package, it does not always do so and Typescript
gets compile errors such as:

Property 'GET /user/{username}/packages' does not exist on
type 'Endpoints'.

Signed-off-by: Chris. Webster <chris@webstech.net>
@octokit-js-project-board octokit-js-project-board bot added this to Inbox in JS Sep 28, 2021
@wolfy1339 wolfy1339 added the bug label Sep 28, 2021
@octokit-js-project-board octokit-js-project-board bot moved this from Inbox to Bugs in JS Sep 28, 2021
@webstech webstech mentioned this pull request Sep 28, 2021
1 task
G-Rath
G-Rath approved these changes Sep 28, 2021
@wolfy1339 wolfy1339 changed the title Fix: Typescript compile failures for old package fix(deps): update @octokit/plugin-paginate-rest to v2.16.4 to fix typescript compile errors Sep 29, 2021
@wolfy1339 wolfy1339 requested a review from gr2m Sep 29, 2021
@gr2m gr2m changed the title fix(deps): update @octokit/plugin-paginate-rest to v2.16.4 to fix typescript compile errors fix(deps): bump minimal version of @octokit/plugin-paginate-rest to v2.16.4 to prevent typescript compile errors Sep 30, 2021
gr2m
gr2m approved these changes Sep 30, 2021
@gr2m gr2m merged commit fca1907 into octokit:master Sep 30, 2021
7 checks passed
Loading
JS automation moved this from Bugs to Done Sep 30, 2021
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 30, 2021

🎉 This PR is included in version 18.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Loading

@webstech
Copy link
Contributor Author

@webstech webstech commented Sep 30, 2021

Thank you to everyone involved. Not just for approving this change but the complete package(s).

Loading

@webstech webstech deleted the paginate-endpoints branch Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
JS
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants