Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout/deadline correction #4

Closed
kamilsk opened this issue Mar 8, 2020 · 1 comment
Closed

timeout/deadline correction #4

kamilsk opened this issue Mar 8, 2020 · 1 comment
Assignees
Labels

Comments

@kamilsk
Copy link
Member

@kamilsk kamilsk commented Mar 8, 2020

time.TimeoutCorrection(http.Header(req.Header).Timeout(time.Second), 10*time.Millisecond)

@kamilsk kamilsk added the help wanted label Mar 8, 2020
@kamilsk kamilsk self-assigned this Mar 8, 2020
@kamilsk

This comment has been minimized.

Copy link
Member Author

@kamilsk kamilsk commented Mar 8, 2020

it may be worth fixing the interface or package structure:

http.Header(req.Header).Timeout(time.Second) -> extended.Header(req.Header).Timeout(time.Second) || config.FromHeader(req.Header).Timeout()

@kamilsk kamilsk closed this in 1f44942 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.