Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not works on VSCode 1.47.0 and later (Windows) #143

Open
MrRefactoring opened this issue Jul 10, 2020 · 15 comments · May be fixed by #144
Open

Does not works on VSCode 1.47.0 and later (Windows) #143

MrRefactoring opened this issue Jul 10, 2020 · 15 comments · May be fixed by #144

Comments

@MrRefactoring
Copy link

MrRefactoring commented Jul 10, 2020

Does not works on VSCode 1.47.0 and later on Windows

Works correctly on MacOS

@utsavsingh899
Copy link

utsavsingh899 commented Jul 11, 2020

I'm having the same issue, please look into this matter ASAP, thanks

@ViniciusALS
Copy link

ViniciusALS commented Jul 15, 2020

I believe I am having the same issue.
I am on VSCode Version 1.47.1

Something is wrong with the character encoding.
code1
code2
code3

@sajadko
Copy link

sajadko commented Jul 16, 2020

same issue on 1.47.1

@MrRefactoring MrRefactoring changed the title Does not works on VSCode 1.47.0 Does not works on VSCode 1.47.0 and later Jul 16, 2020
@WeirdBeardDev
Copy link

WeirdBeardDev commented Jul 17, 2020

same issue on 1.47.2

@djD-REK
Copy link

djD-REK commented Jul 17, 2020

As far as anyone can tell, this is not a maintained repo. Consider https://github.com/kufii/CodeSnap

@WeirdBeardDev
Copy link

WeirdBeardDev commented Jul 19, 2020

@djD-REK thanks for tip, CodeSnap is a good replacement.

@MrRefactoring MrRefactoring changed the title Does not works on VSCode 1.47.0 and later Does not works on VSCode 1.47.0 and later (Windows) Jul 20, 2020
@MrRefactoring MrRefactoring linked a pull request Jul 20, 2020 that will close this issue
@MrRefactoring
Copy link
Author

MrRefactoring commented Jul 20, 2020

I spent a couple of hours and figured out that everything works correctly on macOs. Then I opened this extension on Windows 10 and VSCode 1.47.2 in debugger mode and saw several errors that said that the path to the JavaScript files was incorrect. I took as a basis the path handling methods in this case from the vscode-azure-blockchain-ethereum repository and fixed this issue in #144

Tested on Windows 10 and macOs Catalina

As a workaround, you can use my hotfix extension:
https://marketplace.visualstudio.com/items?itemName=mrrefactoring.polacode-fixed-edition

@utsavsingh899
Copy link

utsavsingh899 commented Jul 21, 2020

Thanks @MrRefactoring It worked like a charm

@thany
Copy link

thany commented Aug 26, 2020

If this repo is not maintained, it should be removed from the extensions marketplace, to keep things clean and not-confusing especially for new/novice users.

@sabarish98
Copy link

sabarish98 commented Sep 7, 2020

I also faced an issue with using it in Windows and @MrRefactoring 's fix works! Thanks man :)

@olucheye
Copy link

olucheye commented Sep 11, 2020

I had initially thought this issue was due to some settings I updated in my VSCode.
Thank you for your fix, @MrRefactoring
It works!

@alabotski
Copy link

alabotski commented Oct 7, 2020

@MrRefactoring Hi I tried your extension but have problems

LOG.error("Error encoding fileName={}", fileName, ex);

code

@MrRefactoring
Copy link
Author

MrRefactoring commented Oct 8, 2020

Not reproduced

code

@alabotski
Copy link

alabotski commented Oct 8, 2020

@MrRefactoring I try this on Mac

@MrRefactoring
Copy link
Author

MrRefactoring commented Oct 9, 2020

@MrRefactoring I try this on Mac

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants