-
Notifications
You must be signed in to change notification settings - Fork 4
Allow datetime timestamps for datafiles; use GCS custom time field for Datafile.timestamp #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow datetime timestamps for datafiles; use GCS custom time field for Datafile.timestamp #154
Conversation
This avoids needless deserialisation.
Posix timestamps are converted to datetime timestamps on Datafile instantiation
Codecov Report
@@ Coverage Diff @@
## release/0.1.17 #154 +/- ##
==================================================
- Coverage 94.61% 94.45% -0.16%
==================================================
Files 54 55 +1
Lines 1542 1570 +28
==================================================
+ Hits 1459 1483 +24
- Misses 83 87 +4
Continue to review full report at Codecov.
|
thclark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but there's a merge conflict since merging the GCS metadata fix branch... and test coverage of the Datafile resource has dropped a bit.
Can you improve the coverage and sort the merge conflict please?
|
Also, @cortadocodes just to check, is it possible for the timestamp to be None? That's a legitimate possibility in doing |
…or/group-datafile-metadata-via-method
Contents
New Features
datetimeand posix timestamps forDatafile.timestampDatafile.posix_timestamppropertyMinor improvements
custom_timemetadata field for storingDatafile.timestampdatetimeobjects directly from blob instead of parsing string serialisationstimeutils moduleHashablefordatetimeinstancesQuality Checklist