Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing benchmarks when pushing multiple commits at once #379

Open
art-w opened this issue Jul 21, 2022 · 2 comments · May be fixed by #482
Open

Missing benchmarks when pushing multiple commits at once #379

art-w opened this issue Jul 21, 2022 · 2 comments · May be fixed by #482
Assignees

Comments

@art-w
Copy link
Contributor

art-w commented Jul 21, 2022

We only benchmark the latest known commit when a git repository is updated... but the git push could have added more than one commit at the same time. If we don't benchmark the intermediate commits, then the graph timeline is harder to read as it doesn't reflect the true git history.

As a bonus, this might help with retro-benchmarking: We currently have to wait for each benchmark to complete, rather than submitting multiple commits corresponding to the different versions in one go!

(related to the removal of old commits #378 which looks a bit easier to handle first)

@punchagan
Copy link
Contributor

#436 is also somewhat related to this.

@ElectreAAS ElectreAAS self-assigned this Aug 22, 2023
@ElectreAAS
Copy link
Contributor

This is being worked on on the bench-old-commits branch

@ElectreAAS ElectreAAS linked a pull request Nov 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants