Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying additional branches to run benchmarks on #426

Closed
punchagan opened this issue Mar 24, 2023 · 0 comments · Fixed by #430
Closed

Support specifying additional branches to run benchmarks on #426

punchagan opened this issue Mar 24, 2023 · 0 comments · Fixed by #430

Comments

@punchagan
Copy link
Contributor

Currently, only the default_branch and PRs are considered when running the benchmarks. It would be useful to specify different tags/branches on which to run the benchmarks. It would be useful to run benchmarks against different versions of development like OCaml 5.0.x and 5.1.x, for instance.

punchagan added a commit to punchagan/current-bench that referenced this issue Mar 30, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Mar 30, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 3, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 12, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 12, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 13, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 13, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 18, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 18, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 21, 2023
punchagan added a commit to punchagan/current-bench that referenced this issue Apr 27, 2023
ElectreAAS pushed a commit that referenced this issue Apr 27, 2023
…pository (#430)

* Filter out branches for benchmarking before setting up metadata

Previously, we filtered out the branches which don't have the required label,
before starting the benchmarking run. But, this meant that the metadata for the
branch is already saved to the DB and displayed in the UI. This commit changes
the filtering to be run before the metadata for the benchmark run is setup.

* Allow specifying a list of branches to benchmark

This would be useful for benchmarking more than one long running branches of a
repository, for instance, the `5.0` and `trunk` branches of ocaml/ocaml.

* Save base branch names of pull requests to the DB

* Add pull_base column to the GraphQL tables

* Allow switching branches from the UI

Closes #426

* Use pullBase to compare benchmarks against correct branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant