Cb check standalone #422
Merged
Cb check standalone #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectreAAS
commented
Mar 9, 2023
ElectreAAS
commented
Mar 9, 2023
ElectreAAS
commented
Mar 9, 2023
art-w
reviewed
Mar 9, 2023
art-w
reviewed
Mar 9, 2023
|
As the CI passes and the error reporting has been improved, I now declare |
punchagan
approved these changes
Mar 16, 2023
ElectreAAS
force-pushed
the
cb-check-standalone
branch
2 times, most recently
from
1020dce
to
2431b43
Compare
ElectreAAS
force-pushed
the
cb-check-standalone
branch
from
2431b43
to
59e96c3
Compare
|
The force-pushes were rebases and a clean-up of the commit history, without changes. As everyone seems happy, I'll merge as-is. |
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes on the important parts of #416, but without the hassle of exposing
cb-schemaas a public toplevel library, which it turns out completely messes up our docker setup.Instead, it is now a library inside the pipeline, which is properly linked to and accessed when needed.
I also incorporated this comment: #416 (comment)