Support using a separate benchmarks repo for benchmarks #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For repositories like ocaml/ocaml, we would like the benchmarks to be maintained potentially by a bigger/different set of users, than the ocaml/ocaml maintainers. This commit adds support for an additional configuration variable that lets us clone an additional repository and run benchmarks from within it. NOTE: No new benchmark runs would be triggered by any changes to the benchmarks repository, with this setup.
art-w
approved these changes
Mar 30, 2023
|
Wow indeed this is a very elegant solution! Bravo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For repositories like ocaml/ocaml, we would like the benchmarks to be maintained potentially by a bigger/different set of users, than the ocaml/ocaml maintainers. This commit adds support for an additional configuration variable that lets us clone an additional repository and run benchmarks from within it.
NOTE: No new benchmark runs would be triggered by any changes to the benchmarks repository, with this setup.
This is a simplistic PR that attempts to implement functionality similar to #370 without the UI hackery.