Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upSummary page #5
Conversation
marbaque
added some commits
Nov 20, 2018
gandalfar
reviewed
Apr 10, 2019
|
I like what you've done with the change. Minor suggestions on what can be improved. |
app/styles/_components.scss
Outdated
| margin-left: 36px; | ||
| height: 100%; | ||
| //margin-left: 36px; | ||
| //height: 100%; |
This comment has been minimized.
This comment has been minimized.
app/styles/_components.scss
Outdated
| &:after { | ||
| content: ""; | ||
| position: absolute; | ||
| right: 0; top: 0; |
This comment has been minimized.
This comment has been minimized.
app/styles/_components.scss
Outdated
| height: 100%; | ||
| width: 48px; | ||
| background: url("svg/graph-icon.svg") no-repeat center center; | ||
| background-color: #158983; |
This comment has been minimized.
This comment has been minimized.
gandalfar
Apr 10, 2019
Member
You can rewrite it into proper shorthand: background: #158983 url("svg/graph-icon.svg") no-repeat center center;
| <img src="assets/images/thanks-2019.svg" class="graphic--world"/> | ||
| </div> | ||
|
|
||
| <div class="medium-6 cell text-center"> | ||
| <img src="assets/images/stats-2019.svg" class="graphic--world graphic--stats"/> | ||
| <div class="summary--button"> | ||
| <a href="/page/summary">2019 Summary<br><span>Click to view full stats</span></a> |
This comment has been minimized.
This comment has been minimized.
gandalfar
Apr 10, 2019
•
Member
Because we're using Ember.js as SPA, this shloud be written as:
{{#link-to "page" "summary"}}
2019 Summary<br/>
<span>Click to view full stats</span>
{{/link-to}}
This way there is no full-page reload on click.
This comment has been minimized.
This comment has been minimized.
marbaque
closed this
Apr 10, 2019
marbaque
reopened this
Apr 10, 2019
gandalfar
merged commit 1abd09a
into
ocwc:master
Apr 11, 2019
This comment has been minimized.
This comment has been minimized.
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
marbaque commentedApr 10, 2019
Added the button to home page and the summary page.