[#611] refactoring toolchain entity #647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #647 +/- ##
===========================================
+ Coverage 62.44% 70.40% +7.96%
===========================================
Files 241 140 -101
Lines 13398 6487 -6911
Branches 370 370
===========================================
- Hits 8366 4567 -3799
+ Misses 4440 1790 -2650
+ Partials 592 130 -462
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lev-titov
force-pushed
the
611-refactoring-toolchain-entity
branch
2 times, most recently
from
4c4ee21
to
85074d5
Compare
lev-titov
force-pushed
the
611-refactoring-toolchain-entity
branch
from
0a9c263
to
e6a8b64
Compare
BPylypenko
requested changes
Dec 23, 2021
| @@ -305,11 +305,11 @@ function local_setup() { | |||
| '.spec.uri=$uri | .spec.username=$username | .spec.password=$password' "${LOCAL_TEST_DATA}/odahuflow/dir/docker-pull-target.json" | jq "." | sponge "${LOCAL_TEST_DATA}/odahuflow/dir/docker-pull-target.json" | |||
|
|
|||
| ## docker image tags | |||
| local ti_version="$(jq -r .mlflow_toolchain_version "${CLUSTER_PROFILE}")" | |||
| local ti_version="$(jq -r .mlflow_training_integration "${CLUSTER_PROFILE}")" | |||
There was a problem hiding this comment.
This should be changed in cluster profiles too. Just a reminder if it's already done.
| toolchain: | ||
| description: IntegrationName of toolchain | ||
| trainingIntegration: | ||
| description: IntegrationName of trainer |
There was a problem hiding this comment.
Suggested change
| description: IntegrationName of trainer | |
| description: Training integration id |
| @@ -64,8 +64,8 @@ type AlgorithmSource struct { | |||
| type ModelTrainingSpec struct { | |||
| // Model Identity | |||
| Model ModelIdentity `json:"model"` | |||
| // IntegrationName of toolchain | |||
| Toolchain string `json:"toolchain"` | |||
| // IntegrationName of trainer | |||
There was a problem hiding this comment.
Suggested change
| // IntegrationName of trainer | |
| // Training integration id |
|
|
||
| IntegrationName of toolchain # noqa: E501 | ||
| IntegrationName of trainer # noqa: E501 |
There was a problem hiding this comment.
Suggested change
| IntegrationName of trainer # noqa: E501 | |
| trainingIntegration id # noqa: E501 |
|
|
||
| IntegrationName of toolchain # noqa: E501 | ||
| IntegrationName of trainer # noqa: E501 |
There was a problem hiding this comment.
Suggested change
| IntegrationName of trainer # noqa: E501 | |
| trainingIntegration id # noqa: E501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #611