[#611] refactoring ui toolchain #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lev-titov
requested review from
owlleg6,
BPylypenko and
GennadiyShpak
and removed request for
owlleg6,
BPylypenko and
GennadiyShpak
GennadiyShpak
approved these changes
Dec 21, 2021
BPylypenko
reviewed
Dec 21, 2021
| @@ -66,9 +66,9 @@ export interface ModelTrainingSpec { | |||
| resources?: models.ResourceRequirements; | |||
|
|
|||
| /** | |||
| * IntegrationName of toolchain | |||
| * IntegrationName of trainer | |||
There was a problem hiding this comment.
Suggested change
| * IntegrationName of trainer | |
| * Training integration id |
| import {PackagingURLs} from "../packagings/urls"; | ||
| import {fetchUserInfoRequest} from "../../store/user/actions"; | ||
| import {TrainingIntegration} from "../../models/odahuflow/TrainingIntegration"; |
There was a problem hiding this comment.
don't see where this import is used
| @@ -17,7 +17,7 @@ const headers = ['Image pull connection ID', 'Image', 'Replicas', 'State', 'Crea | |||
| const extractRow = (md: ModelDeployment) => [ | |||
| ( | |||
| <RouterLink | |||
| key="toolchain" | |||
| key="trainingIntegration" | |||
There was a problem hiding this comment.
Suggested change
| key="trainingIntegration" | |
| key="imagePullConnIDLink" |
Looks like it's more close to real meaning of it.
owlleg6
approved these changes
Dec 22, 2021
BPylypenko
requested changes
Dec 23, 2021
| import {TrainingIntegration} from "../../models/odahuflow/TrainingIntegration"; | ||
|
|
||
| export enum TrainingIntegrationActionTypes { | ||
| FETCH_ALL = '@@trainingIntegrationFETCH_ALL', |
There was a problem hiding this comment.
Suggested change
| FETCH_ALL = '@@trainingIntegrationFETCH_ALL', | |
| FETCH_ALL = '@@trainingIntegration/FETCH_ALL', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue odahu/odahu-flow#611