Skip to content
This repository has been archived by the owner on Jun 27, 2020. It is now read-only.

27 fix violations and remove rubocop todo yml #28

Merged
merged 3 commits into from Oct 11, 2018

Conversation

kfrz
Copy link
Contributor

@kfrz kfrz commented Oct 11, 2018

Background

As a developer I do not want to have extant rubocop violations in the code base.

Fix violations and remove the todo file.

Definition of Done

  • All violations in .rubocop_todo.yml are fixed
  • .rubocop_todo.yml is removed
  • Rubocop passes

* Add exclusions for migrations and config files
* Remove .rubocop_todo.yml entries
Copy link
Contributor

@hpjaj hpjaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kfrz kfrz merged commit eb1c0d2 into master Oct 11, 2018
@kfrz kfrz deleted the 27-fix-violations-and-remove-rubocop-todo-yml branch October 11, 2018 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants