This repository has been archived by the owner on Sep 29, 2022. It is now read-only.
DRF-channels blog post #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacyk
approved these changes
Dec 7, 2018
| serializers.py | ||
| views.py | ||
|
|
||
| As a side note, for something that I'm not distributing as a library, I |
There was a problem hiding this comment.
This makes me think we should add a "side note" type of style to our pattern library. Not now, but in a far future story :)
There was a problem hiding this comment.
mirisuzanne
reviewed
Dec 7, 2018
There was a problem hiding this comment.
This is good!
- At a certain point, it becomes large code-blocks, with most of the commentary in code-comments. I can see advantages and disadvantages to that approach – more integrated, but also feels more monolithic.
- Overall there's a strong tone that "you probably already know most of this". I might try to pull that back a bit - a more subtle/tonal form of the best-practice against using "just" or "simply".
* master: Hotfix headline type null 🐈 Upgrade deps Address review Update talks and workshops
|
@mirisuzanne I appreciate those two points. I've tried to address both, and would be interested in your take on whether I succeeded. |
jgerigmeyer
approved these changes
Dec 10, 2018
|
@jgerigmeyer clearly I meant to include this image: http://www.lachanelphile.com/wp-content/uploads/2012/10/No5_EXTRAIT_02.jpg |
|
@wlonk I wondered! |
|
This is ready to merge and publish whenever anyone else says it is. We should tweak the date before publishing though? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I welcome feedback on this!