This repository has been archived by the owner on Sep 29, 2022. It is now read-only.
always return blog posts by descending date; simplify bird-name getting #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgerigmeyer
commented
Feb 23, 2017
modules/pages.py
Outdated
| @@ -103,9 +105,8 @@ def predicate(x, key): | |||
|
|
|||
|
|
|||
| def make_get_blog_entries_by_bird(builder): | |||
There was a problem hiding this comment.
Now that we're not doing anything in the parent make_* method, is there a simpler way to do this in Python? In JS, I would use bind to create a partial. Oh hey, I found it; pushing... :)
wlonk
approved these changes
Feb 24, 2017
| builder, | ||
| ) | ||
| env.globals['get_blog_entries_by_tag'] = make_get_blog_entries_by_tag( | ||
| env.globals['get_blog_entries_by_tag'] = partial( | ||
| get_blog_entries_by_tag, |
There was a problem hiding this comment.
Oh, I much prefer this style. Thanks.
davisagli
approved these changes
Feb 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.