Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID attrs have invalid and inconsistent characters. #106

Closed
1 task done
jgerigmeyer opened this issue May 26, 2017 · 3 comments
Closed
1 task done

ID attrs have invalid and inconsistent characters. #106

jgerigmeyer opened this issue May 26, 2017 · 3 comments
Assignees
@jgerigmeyer
Labels
bug ready for review
Milestone
Herman 1.0

Comments

@jgerigmeyer
Copy link
Member

jgerigmeyer commented May 26, 2017 •
edited

Some IDs are using spaces , while others are encoded using %20. Internal hash links are broken.

TODO:

  • all id attr contents should be safe; only valid chars
@jgerigmeyer jgerigmeyer added this to the Herman 1.0 milestone May 26, 2017
@mirisuzanne mirisuzanne mentioned this issue Jun 3, 2017
Closed
@davisagli
Copy link
Contributor

Can you be more specific about where this is happening?

@jgerigmeyer
Copy link
Member Author

jgerigmeyer commented Jun 19, 2017 •
edited

@davisagli There are two related issues I'm concerned about:

  1. Inconsistent (broken) links. For instance, on the code page, the links to the Code Blocks section have href="code.html#css--Code Blocks", which is both invalid HTML and also doesn't match the section id="css--Code%20Blocks". The difference is between the id var set in item/_item.j2 and the url created by the get_link macro in item/macros.j2, used in item/annotation.macros.j2.

  2. Invalid characters in id attributes. Even in HTML5, id attributes should not contain whitespace, and must begin with a letter (or at least that's my understanding). If we're using dynamic content to generate id attributes, I want to be sure we're following the spec.

screenshot 2017-06-19 15 59 33

@jgerigmeyer jgerigmeyer assigned jgerigmeyer and unassigned davisagli Oct 17, 2017
@jgerigmeyer jgerigmeyer mentioned this issue Oct 17, 2017
Merged
@jgerigmeyer
Copy link
Member Author

Item #1 is fixed and PR is ready for review: #171.

Re item #2, I reviewed all id attributes, and they are already valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgerigmeyer jgerigmeyer

Labels
bug ready for review
Projects
None yet
Milestone
Herman 1.0
Development

No branches or pull requests
2 participants
@davisagli @jgerigmeyer