Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong container width when using rem in IEs #554

Closed
hoffi opened this Issue Dec 16, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@hoffi
Copy link
Contributor

hoffi commented Dec 16, 2015

The width of my container is 950px and the Base Font-Size is 16px, this gives a rem-Value of 59,375.

But IE seems to only accept values with two decimal places, as it always uses 59,37rem. The container is now 0,08px to small in IE and so the contents do not fit into the container anymore and start wrapping.

As a workaround is there a way to just disable the use of rem for the container?

@mirisuzanne

This comment has been minimized.

Copy link
Member

mirisuzanne commented Dec 19, 2015

Susy doesn't convert your container value to rems. Can you show me a sample of your code? What's your $susy config look like, and how are you calling container()?

@hoffi

This comment has been minimized.

Copy link
Contributor Author

hoffi commented Dec 21, 2015

Hi, im using susyone and im just calling it this way: @include container;

My settings:

$total-columns: 24;
$column-widht: 30px;
$gutter-width: 10px;
$container-style: static;
$grid-padding: 0;

If i look at this mixin it does set rem values.

@mirisuzanne

This comment has been minimized.

Copy link
Member

mirisuzanne commented Dec 22, 2015

Huh, I think that's a bug in Compass. That function is only meant to convert rem to px for fallback, not the other way around. Strange that we haven't seen it until now. It's also a bug with big repercussions if we fix it: we'd have to deprecate and break backwards-compatibility. With Compass end-of-lifed, that's not very likely. We could make the change here, but I don't really want to maintain SusyOne indefinitely either. This sounds like your starting a new project, is there a reason you're using an old version of Susy?

@hoffi

This comment has been minimized.

Copy link
Contributor Author

hoffi commented Dec 22, 2015

It is not a new project. We have updated susy from an older version because of a rails upgrade.

Would it be possible to introduce a setting which would turn the rem off?

@mirisuzanne

This comment has been minimized.

Copy link
Member

mirisuzanne commented Dec 22, 2015

Sure! Want to submit a PR?

@hoffi

This comment has been minimized.

Copy link
Contributor Author

hoffi commented Jan 7, 2016

When is a new version containing this fix planned?

@mirisuzanne

This comment has been minimized.

Copy link
Member

mirisuzanne commented Jan 7, 2016

Done!

@mirisuzanne mirisuzanne closed this Jan 7, 2016

@mirisuzanne

This comment has been minimized.

Copy link
Member

mirisuzanne commented Jan 7, 2016

2.2.10

@hoffi

This comment has been minimized.

Copy link
Contributor Author

hoffi commented Jan 7, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.