Clipping revamp #100
Closed
Clipping revamp #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrollable container's delayed content touch would send a touchEnded event with the 'inside' flag set to false when you started dragging the container (cancelling the touch), meaning the element would get activated anyway. Fixed by sending the event with inside=false, which makes most controls ignore the interaction.
Instead of having a single master function to clip everything, added a virtual function to the base element class, which handles clipping that element and all children to a screen-space clip rectangle. Override as needed.
Clipping is now entirely handled with rects, with no special casing done on the clipping direction. Several display related variables are now used in a more consistent manner, or have been renamed to follow their actual usage. In addition to being less code, the new solution is more flexible, allowing clipping from all sides at once.
Avoid recursing down to children when the sprite's visibility hasn't changed. This is a safe assumption when the parent object bounds the children, and makes scrolling with many text objects much smoother.
|
Closing stale old PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of changes (almost complete rewrite) to the clipping system. See full commit messages for more info. I tested it on my project and everything seems to work, but I'm not sure if I got all the uses involving width/_width right. Comments appreciated.
This change is