Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drive should fail (non-zero exit status) if the user cancels an operation #460

Closed
smblott-github opened this Issue Nov 5, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@smblott-github
Copy link

smblott-github commented Nov 5, 2015

When asked to confirm an operation -- Y/n -- if the user hits n, then the exit status should be non-zero.

  • The operation did not complete successfully, so 0 is inappropriate.
  • The "quick hack" in #459 doesn't work correctly because of this.

(@odeke-em... I'm new to drive, so I'm just discovering the things which don't work well with my workflow. I hope you don't mind all of the issues.)

@odeke-em

This comment has been minimized.

Copy link
Owner

odeke-em commented Nov 5, 2015

Oh not all, good stuff discovering these cases makes drive better.
I'll most likely start working on the issues on Friday(~38 hours) because that's when I start a break of a week off. In the mean time, please go on, I appreciate the usage and issue discovery!

@odeke-em odeke-em added this to the v0.3.3 milestone Nov 7, 2015

@odeke-em odeke-em self-assigned this Nov 7, 2015

@odeke-em

This comment has been minimized.

Copy link
Owner

odeke-em commented Nov 7, 2015

Hello @smblott-github I've addressed this issue with PR #466. Please get the latest from master.
Thank you for reporting this issue and actual this is useful to indicate to the world when the user has rejected the terms.

@smblott-github

This comment has been minimized.

Copy link
Author

smblott-github commented Nov 7, 2015

Closing (in light #466).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.