Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading from 0.3.1 to 0.3.2, all directories show as modified #471

Closed
cdown opened this Issue Nov 9, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@cdown
Copy link

cdown commented Nov 9, 2015

I just upgraded from 0.3.1 to 0.3.2, and on drive pull now all directories show as modified, when they in fact were not. A sample of my output:

M /Images
M /Images/2015-08
M /Images/2015-08/Peakop
M /Images/2015-07
M /Images/2015-07/MQ

The end then says:

Modification count 255 src: 816.11KB dest: 838.16KB
Addition count 2 src: 20.70MB
Proceed with the changes? [Y/n]:

The addition count appears to be correct, but no modifications to those directories took place, as far as I know. For now I've not updated since I'm worried about what might happen.

Any ideas?

% drive version
drive version: 0.3.2
Commit Hash: '848497f4ba68050820f32e1e54266e1eba2d5189'
Go Version: go1.5.1
OS: linux/amd64
BuildTime: 2015-11-09 11:10:14.928305808 +0000 GMT
@odeke-em

This comment has been minimized.

Copy link
Owner

odeke-em commented Nov 9, 2015

Hello again @cdown,
Yes that's right there was a bug previously that prevented the match of ModTimes with remote folders that I noticed after drive touch folders && drive pull folders in which the pull was always ignored. I noticed that in issue #463. This meant that if you did a drive stat as well as ls -l on the same folders, the modTimes differed before last Friday's commit.

For now that's gonna be a seemingly spurious change but better to get all the times matching now than later. It is necessary later on to help with conflict detection.

@cdown

This comment has been minimized.

Copy link
Author

cdown commented Nov 10, 2015

Awesome, thanks @odeke-em!

@cdown cdown closed this Nov 10, 2015

@odeke-em

This comment has been minimized.

Copy link
Owner

odeke-em commented Nov 10, 2015

Cheers @cdown!

@odeke-em odeke-em added this to the v0.3.3 milestone Nov 21, 2015

@odeke-em odeke-em added the bug label Nov 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.