Removal of the Old Backend #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisDevDane
reviewed
Apr 26, 2021
Member
ThisDevDane
left a comment
ThisDevDane
left a comment
There was a problem hiding this comment.
I mainly only looked at the CI-related stuff
|
|
||
| case BuildFlag_UseLLVMApi: | ||
| build_context.use_llvm_api = true; | ||
| gb_printf_err("-llvm-api flag is not required any more\n"); |
Member
There was a problem hiding this comment.
Why error out on the flag specifically? I don't remember Odin yelling at you about unknown flags?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total removal of the old backend in favour of the backend using the integrated LLVM C API.