This repository has been archived by the owner on May 5, 2021. It is now read-only.
[ADD] Core: handle basic enter #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zynton
force-pushed
the
master-enter-age
branch
from
144c4af
to
a48f47f
Compare
Zynton
force-pushed
the
master-fixes-age
branch
12 times, most recently
from
d2b1aff
to
c012d45
Compare
Zynton
force-pushed
the
master-enter-age
branch
2 times, most recently
from
a712e88
to
d351a27
Compare
|
@dmo-odoo Updated. |
Zynton
force-pushed
the
master-fixes-age
branch
from
5786e6b
to
72ca249
Compare
dmo-odoo
force-pushed
the
master-fixes-age
branch
from
72ca249
to
898bdd4
Compare
|
@Zinston Looks like it's not rebased on master after our merges of last wednesday ;-) |
Zynton
force-pushed
the
master-enter-age
branch
from
d351a27
to
c9ff27d
Compare
Now it is ;-) |
Merged
dmo-odoo
reviewed
Nov 19, 2019
Zynton
force-pushed
the
master-enter-age
branch
3 times, most recently
from
7d43bef
to
a11b902
Compare
|
@dmo-odoo Ready. There were three more fixes I wanted to move here from master-coretests-age, but there were apparently a lot of things to discuss regarding those (038aa57, 8ef1f73 and c70d654). |
Zynton
commented
Nov 25, 2019
dmo-odoo
reviewed
Nov 25, 2019
Zynton
force-pushed
the
master-enter-age
branch
from
d449893
to
fe022b9
Compare
Co-authored-by: Antoine Guenet <age@odoo.com> Co-authored-by: David Monjoie <dmo@odoo.com>
When implementing SHIFT+ENTER, I needed to inspect the 'insert' intent's payload value, which had to be a LineBreakNode. However, all I could see in the DevTools was "Object object". So I implemented an override of toString on the VNode object so it could be conveniently inspected.
Eg: `<paragraph>[]</paragraph>` <=> `<p>[]<br></p>` The info component's selection tab was unable to show this, and made the DevTools crash.
Until this commit, the Parser just added a LINE_BREAK in VDocument for each <br>. But our own Renderer doesn't render a single <br> for each LINE_BREAK. This commit makes the Parser consistent with that behaviour. Also includes tests to account for that.
dmo-odoo
force-pushed
the
master-enter-age
branch
from
fe022b9
to
499f7ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.