From 433c7124117e08102de3c209014890b645f11710 Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Thu, 25 Apr 2024 14:11:58 +0200 Subject: [PATCH] [FIX] account,purchase,sale: wrong mail thread method signature Since 3eb96806022705f5b667e149ffa2240760097278, the signature of method `_notify_by_email_prepare_rendering_context` has been changed to provide a default values to `msg_vals` and some overrides were not adapted (or have been added afterwards). No true bug/issue has been found caused by that discrepancy, but for consistency, this commit makes sure those overrides are adapted to provide the same API as the parent method. Fixes #162742 X-original-commit: d4b31842d6c3e1c5c86d9019a353601914ebf1f7 --- addons/account/models/account_move.py | 2 +- addons/purchase/models/purchase.py | 2 +- addons/sale/models/sale_order.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/account/models/account_move.py b/addons/account/models/account_move.py index 962ce6074f91d..e7cdbb7773f41 100644 --- a/addons/account/models/account_move.py +++ b/addons/account/models/account_move.py @@ -4638,7 +4638,7 @@ def _creation_message(self): 'in_receipt': _('Purchase Receipt Created'), }[self.move_type] - def _notify_by_email_prepare_rendering_context(self, message, msg_vals, model_description=False, + def _notify_by_email_prepare_rendering_context(self, message, msg_vals=False, model_description=False, force_email_company=False, force_email_lang=False): # EXTENDS mail mail.thread render_context = super()._notify_by_email_prepare_rendering_context( diff --git a/addons/purchase/models/purchase.py b/addons/purchase/models/purchase.py index 2a6f885557b8d..0cc6cbe32143a 100644 --- a/addons/purchase/models/purchase.py +++ b/addons/purchase/models/purchase.py @@ -393,7 +393,7 @@ def _notify_get_recipients_groups(self, message, model_description, msg_vals=Non return groups - def _notify_by_email_prepare_rendering_context(self, message, msg_vals, model_description=False, + def _notify_by_email_prepare_rendering_context(self, message, msg_vals=False, model_description=False, force_email_company=False, force_email_lang=False): render_context = super()._notify_by_email_prepare_rendering_context( message, msg_vals, model_description=model_description, diff --git a/addons/sale/models/sale_order.py b/addons/sale/models/sale_order.py index 8a38afb9299d4..96f67df045bb2 100644 --- a/addons/sale/models/sale_order.py +++ b/addons/sale/models/sale_order.py @@ -1447,7 +1447,7 @@ def _notify_get_recipients_groups(self, message, model_description, msg_vals=Non return groups - def _notify_by_email_prepare_rendering_context(self, message, msg_vals, model_description=False, + def _notify_by_email_prepare_rendering_context(self, message, msg_vals=False, model_description=False, force_email_company=False, force_email_lang=False): render_context = super()._notify_by_email_prepare_rendering_context( message, msg_vals, model_description=model_description,