From ce6849548a0084f41798406e2d45706bb6d4b65f Mon Sep 17 00:00:00 2001
From: "Christihan Laurel [Vauxoo]" <laurel@vauxoo.com>
Date: Thu, 21 Mar 2024 22:24:31 +0000
Subject: [PATCH] [FIX] Payment: prevent error in rendering payment icon list
 with PIL incompatible icon image formats

Replace the use of 't-esc' with 't-field' for the payment icon image in
the icons list template. The latter, for an image field, provides two
options for rendering the payment icon image: use the PIL library to
obtain the image when given the option 'qweb_img_raw_data', or use a
URL. The former only considers the first option, allowing only image
formats compatible with the PIL library.

closes odoo/odoo#159586

X-original-commit: bc76cca37504b40eac73190363c452f89dca65ed
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
---
 addons/payment/views/payment_form_templates.xml | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/addons/payment/views/payment_form_templates.xml b/addons/payment/views/payment_form_templates.xml
index e088b092bc491..35b0dd22fe568 100644
--- a/addons/payment/views/payment_form_templates.xml
+++ b/addons/payment/views/payment_form_templates.xml
@@ -228,8 +228,7 @@
             </div>
             <!-- === Payment method logo === -->
             <div t-call="payment.form_logo">
-                <t t-set="logo" t-value="token_sudo.payment_method_id.image_payment_form"/>
-                <t t-set="title" t-value="token_sudo.payment_method_id.name"/>
+                <t t-set="logo_pm_sudo" t-value="token_sudo.payment_method_id"/>
             </div>
         </div>
         <!-- === Inline form === -->
@@ -309,8 +308,7 @@
                         <t t-set="pm_index" t-value="0"/>
                         <t t-foreach="pms_to_display_sudo" t-as="pm_to_display_sudo">
                             <t t-if="pm_index &lt; 4" t-call="payment.form_logo">
-                                <t t-set="logo" t-value="pm_to_display_sudo.image_payment_form"/>
-                                <t t-set="title" t-value="pm_to_display_sudo.name"/>
+                                <t t-set="logo_pm_sudo" t-value="pm_to_display_sudo"/>
                             </t>
                             <t t-set="pm_index" t-value="pm_index + 1"/>
                         </t>
@@ -383,13 +381,13 @@
 
     <template id="payment.form_logo" name="Form Logo">
         <!-- Parameters description:
-            - logo: The logo to display, as an `Image` field.
-            - title: The title to display on hover.
+            - logo_pm_sudo: The payment method whose logo to display, as a sudoed `payment.method`
+                            record.
         -->
-        <span t-out="logo"
+        <span t-field="logo_pm_sudo.image_payment_form"
               t-options="{'widget': 'image', 'alt-field': 'name'}"
               class="position-relative d-block rounded overflow-hidden z-index-1 shadow-sm"
-              t-att-title="title"
+              t-att-title="logo_pm_sudo.name"
               data-bs-toggle="tooltip"
               data-bs-placement="top"
               data-bs-delay="0"