[IMP] web: throw error when a domain is invalid #787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancoisGe
force-pushed
the
master-wowl-fge
branch
4 times, most recently
from
216eb6c to
ebd7120
Compare
ged-odoo
reviewed
May 3, 2021
addons/web/static/src/core/domain.js
Outdated
There was a problem hiding this comment.
probably should create a InvalidDomainError class, subclassing OdooError.
FrancoisGe
force-pushed
the
master-wowl-fge
branch
7 times, most recently
from
1c3c03f to
af0740d
Compare
aab-odoo
force-pushed
the
master-wowl
branch
2 times, most recently
from
a0c2610 to
d6a5cb2
Compare
FrancoisGe
force-pushed
the
master-wowl-fge
branch
from
af0740d to
2cee427
Compare
|
just testing stuff, ignore me. @robodoo r+ |
|
I'm sorry, @Xavier-Do. I'm afraid I can't do that. |
|
Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it. |
|
@robodoo r+ |
|
I'm sorry, @Xavier-Do. I'm afraid I can't do that. |
|
sudo |
|
@robodoo r- |
FrancoisGe
force-pushed
the
master-wowl-fge
branch
from
2cee427 to
32c246f
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 20, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 14, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
closes #787 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.