Master wowl dates boi #867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ged-odoo
reviewed
May 25, 2021
brboi
force-pushed
the
master-wowl-dates-boi
branch
from
7420f36 to
885a63a
Compare
|
Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it. |
|
robodoo r+ |
|
@brboi runbot is red |
brboi
force-pushed
the
master-wowl-dates-boi
branch
from
885a63a to
7f523a3
Compare
Author
Yes... I had an issue with https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/test#using_test_on_a_regex_with_the_global_flag Solved. @ged-odoo I also changed the DateTime.prototype.toJSON. See last item in commit message No other changes since your last review than lines:
|
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch
brboi
force-pushed
the
master-wowl-dates-boi
branch
from
7f523a3 to
8543d95
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 26, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
May 31, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 7, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 8, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 14, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
- file is now ordered by clean sections - `confirm()` helper has been renamed to something more appropriate - `strftimeToLuxonFormat()` was manually cached. It now uses `memoize()` from `core/utils/functions` - memoization of `stripAlphaDupes()` because it is prone to get called really often with same arguments. - no more export `parseSmartDateInput()` as it is never imported elsewhere. - remove unecessary `setLocale` call in `luxon.DateTime.prototype.toJSON` patch closes #867 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date utils: create sections ?? + date utils confirm => isValidDateTime + there's a comment about replacing returns false with DateTime.invalid(reason)