Skip to content

Conversation

@larm-odoo
Copy link
Contributor

New expense cards created - documentation needed. This was requested on this task card.

Original task card for this doc.

@robodoo
Copy link
Collaborator

robodoo commented Nov 6, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team November 6, 2025 20:54
@larm-odoo larm-odoo marked this pull request as draft November 7, 2025 14:53
@larm-odoo larm-odoo self-assigned this Nov 7, 2025
@larm-odoo larm-odoo added the 5 label Nov 7, 2025
@larm-odoo larm-odoo force-pushed the 19.0-expenses-expense-card-larm branch 2 times, most recently from 1dcee2c to 7767125 Compare November 10, 2025 21:08
@larm-odoo larm-odoo marked this pull request as ready for review November 10, 2025 21:09
@larm-odoo larm-odoo requested a review from Laura-labe November 10, 2025 21:09
@larm-odoo larm-odoo force-pushed the 19.0-expenses-expense-card-larm branch from 7767125 to dc7c7d2 Compare November 10, 2025 21:38
@larm-odoo
Copy link
Contributor Author

Hello @Laura-labe - I have completed my first draft of the expense card doc. I cannot test this yet, so I only have one screenshot. I wanted to make sure what I have in here is accurate, as my database can only show me so much, without actually being connected and making transactions.

Copy link

@Laura-labe Laura-labe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @larm-odoo , thank you for your nice work :) I just reviewed the documentation and added some changes requests. Could you please have a look? Thank you!

PS: Feel free to rephrase any of the suggestions I provided, they’re intended to convey the key ideas I’d like to highlight.

@larm-odoo larm-odoo force-pushed the 19.0-expenses-expense-card-larm branch from dc7c7d2 to 2f71801 Compare November 14, 2025 20:16
@larm-odoo
Copy link
Contributor Author

Thank you SO much @Laura-labe! Would you please check all my changes and make sure there is nothing else you want added? Thank yoU!

@larm-odoo larm-odoo requested a review from Laura-labe November 14, 2025 20:17
@Laura-labe
Copy link

Hello @larm-odoo , thank you for your quick changes :) I added 2 small comments about the Stripe set up and the IOS availability of the virtual card. After those modifications, we'll be good to go. Thank you!

@larm-odoo larm-odoo force-pushed the 19.0-expenses-expense-card-larm branch from 2f71801 to ef130d4 Compare November 17, 2025 15:23
@larm-odoo
Copy link
Contributor Author

Thank you so much @Laura-labe! I've implemented the changes, and am sending this off for final review so it can be published.

@larm-odoo larm-odoo requested a review from Felicious November 17, 2025 15:24
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - this has been revoewed and approved by Laura (LABE) so this is ready for a final tech review. Thank you!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work on this PR, @larm-odoo !

Approving with a really minor and optional nitpick (:

@robodoo delegate+

@larm-odoo larm-odoo force-pushed the 19.0-expenses-expense-card-larm branch from ef130d4 to 46e216f Compare November 18, 2025 14:08
@larm-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants