-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[ADD] Expenses: Expense cards #15154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1dcee2c to
7767125
Compare
7767125 to
dc7c7d2
Compare
|
Hello @Laura-labe - I have completed my first draft of the expense card doc. I cannot test this yet, so I only have one screenshot. I wanted to make sure what I have in here is accurate, as my database can only show me so much, without actually being connected and making transactions. |
Laura-labe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @larm-odoo , thank you for your nice work :) I just reviewed the documentation and added some changes requests. Could you please have a look? Thank you!
PS: Feel free to rephrase any of the suggestions I provided, they’re intended to convey the key ideas I’d like to highlight.
dc7c7d2 to
2f71801
Compare
|
Thank you SO much @Laura-labe! Would you please check all my changes and make sure there is nothing else you want added? Thank yoU! |
|
Hello @larm-odoo , thank you for your quick changes :) I added 2 small comments about the Stripe set up and the IOS availability of the virtual card. After those modifications, we'll be good to go. Thank you! |
2f71801 to
ef130d4
Compare
|
Thank you so much @Laura-labe! I've implemented the changes, and am sending this off for final review so it can be published. |
|
Hi @Felicious - this has been revoewed and approved by Laura (LABE) so this is ready for a final tech review. Thank you! |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work on this PR, @larm-odoo !
Approving with a really minor and optional nitpick (:
@robodoo delegate+
ef130d4 to
46e216f
Compare
|
@robodoo r+ |

New expense cards created - documentation needed. This was requested on this task card.
Original task card for this doc.