[IMP] CRM: updating flow and screenshots about lead mining #2535

StraubCreative · 2022-07-31T22:10:48Z

Task: 2543815
Cherry pick from #998

Omitted changes proposed in the track_leads directory (e.g. lead_scoring.rst + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary.

What’s left over are the original proposed changes in #998, within the acquire_leads directory which include updates to lead_mining.rst and corresponding image files.

On top of these proposals, I went ahead and made the following changes:

renamed the image files in the acquire_leads asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png)
cleaned up RST formatting issues (headings, line breaks, lists, broken links, guilabels, etc.)
rewrote select content to be more concise and follow content guidelines. You can see the first version of proposals here to compare the changes made.

robodoo · 2022-07-31T22:11:11Z

Pull request status dashboard.

StraubCreative · 2022-07-31T22:32:52Z

Hi @meng-odoo

For content review please do the following:

confirm that I captured the essence of what Tori was originally proposing here for lead_mining.rst
ensure the content (copy + screenshots) clearly and accurately illustrates the features for lead mining
double check XPL review on [IMP] CRM: updating flow and screenshots about lead mining #998 to see if I hit most/all of what they suggested be changed
let me know if we need to change or add anything (this cherry-pick is from a PR that's 14-months old...good chance something is missing or some content is out-of-date).

Thank you 🙏

cc: @mivu-odoo

StraubCreative · 2022-09-23T20:25:32Z

Nudge @meng-odoo
cc: @mivu-odoo

meng-odoo

Hi @samueljlieber (cc: @StraubCreative @mivu-odoo), I've made a few changes to this old cherry-picked PR. Mostly fixing small typos, wording/formatting issues, and adding/clarifying information---plus replacing one image. Please let me know if you have any questions :) Thanks!

content/applications/sales/crm/acquire_leads/lead_mining.rst

samueljlieber · 2022-09-28T14:59:45Z

Hi @meng-odoo 👋
I made your changes to the document and updated the image. I also added a :guilabel: to line 22:

After the :guilabel:Lead Mining setting is activated...

Thanks for the content updates! Let me know if you have more changes :)

meng-odoo

Hey @samueljlieber, thanks for making those changes! I just have a couple more here that weren't caught the first time around. Please let me know if you have any questions. Thanks :)

content/applications/sales/crm/acquire_leads/lead_mining.rst

samueljlieber · 2022-09-29T18:24:39Z

Hi @meng-odoo! Your changes have been made 👍

meng-odoo

Hi @samueljlieber thanks for making those changes! I'm sorry, I found one more change that should be made to the new image I added (adding a red box to match the related image right before it). After we update the image, we should be good :)

content/applications/sales/crm/acquire_leads/lead_mining.rst

samueljlieber · 2022-09-30T14:10:04Z

All set @meng-odoo 🙂 Thanks!

meng-odoo

Looks great @samueljlieber, thank you! I'll tag the next reviewer

mivu-odoo

Hello @meng-odoo and @samueljlieber!

Nice work on this PR, very clean! I found a couple of small edits. Please tag me again for a second look once you finish integrating the suggestions. Thank you 😸

content/applications/sales/crm/acquire_leads/lead_mining.rst

samueljlieber · 2022-10-04T19:34:48Z

Hi @mivu-odoo!
I implemented your changes, ready for another look! Thank you! 🙂

mivu-odoo

Hello @samueljlieber!

Thank you for the quick turnaround! I found one small verb tense edit. Once that change is made, feel free to go straight to ZST for final technical review, no need to tag me again. Thank you 😸

content/applications/sales/crm/acquire_leads/lead_mining.rst

samueljlieber · 2022-10-07T13:16:33Z

Thank you @mivu-odoo! Hi @StraubCreative 👋 this doc is ready for your review!

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made.

StraubCreative

Hi @meng-odoo 👋
Clean PR, nice job.
Approving, with the following CR's addressed in the commit that follows.

StraubCreative · 2022-12-05T22:20:26Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

-`Odoo GDPR <http://odoo.com/gdpr>`__, 
+.. note::
+   Make sure to be aware of the latest EU regulations when receiving contact information. Get more
+   information about the General Data Protection Regulation on `Odoo GDPR <http://odoo.com/gdpr>`__.


Only one underscore is needed for the link.

Suggested change

information about the General Data Protection Regulation on `Odoo GDPR <http://odoo.com/gdpr>`__.

information about the General Data Protection Regulation on `Odoo GDPR <http://odoo.com/gdpr>`_.

StraubCreative · 2022-12-05T22:20:52Z

content/applications/sales/crm/acquire_leads/lead_mining.rst

+   See here for full pricing information: `Lead Generation by Odoo IAP <https://iap.odoo.com/iap/
+   in-app-services/167?>`__.


Same here. Only one underscore for the link.

Suggested change

See here for full pricing information: `Lead Generation by Odoo IAP <https://iap.odoo.com/iap/

in-app-services/167?>`__.

See here for full pricing information: `Lead Generation by Odoo IAP <https://iap.odoo.com/iap/

in-app-services/167?>`_.

StraubCreative · 2022-12-05T22:26:02Z

4af536d addresses merge conflicts from #2983 and outdated 14.0 content.

Also includes fixes to change requests above.

StraubCreative · 2022-12-05T22:27:03Z

@odoo/doc-review you're up 🙂
I think this is the last PR from the VPK pipeline.
Thanks!

AntoineVDV

@robodoo r+

Task: 2543815 Cherry pick from #998 Omitted changes proposed in the **track_leads** directory (e.g. `lead_scoring.rst` + image folder). Both the content and image updates were already pushed from another PR so what was proposed on #998 was outdated and no longer necessary. What’s left over are the original proposed changes in #998, within the **acquire_leads** directory which include updates to `lead_mining.rst` and corresponding image files. On top of these proposals, I went ahead and made the following changes: - renamed the image files in the asset directory, since they were using outdated naming convention (e.g. LM1.png, LM6.png, LM7.png) - cleaned up rst formatting issues (headings, line breaks, added guilabels, etc.) - rewrote document so content was more concise + followed content guidelines. You can see the first version of proposals here to compare the changes made. closes #2535 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

StraubCreative mentioned this pull request Jul 31, 2022

[IMP] CRM: updating flow and screenshots about lead mining #998

Closed

C3POdoo requested a review from a team July 31, 2022 22:12

StraubCreative self-assigned this Jul 31, 2022

StraubCreative assigned samueljlieber Sep 23, 2022

meng-odoo suggested changes Sep 28, 2022

View reviewed changes

samueljlieber force-pushed the 14.0-crm-lead-mining-vpk-2 branch from 0da0f29 to ec65f87 Compare September 28, 2022 14:52

samueljlieber requested a review from meng-odoo September 28, 2022 14:59

meng-odoo suggested changes Sep 28, 2022

View reviewed changes

content/applications/sales/crm/acquire_leads/lead_mining.rst Outdated Show resolved Hide resolved

content/applications/sales/crm/acquire_leads/lead_mining.rst Outdated Show resolved Hide resolved

samueljlieber force-pushed the 14.0-crm-lead-mining-vpk-2 branch from ec65f87 to bd1554c Compare September 29, 2022 18:22

samueljlieber requested a review from meng-odoo September 29, 2022 18:24

meng-odoo suggested changes Sep 29, 2022

View reviewed changes

content/applications/sales/crm/acquire_leads/lead_mining.rst Outdated Show resolved Hide resolved

samueljlieber force-pushed the 14.0-crm-lead-mining-vpk-2 branch from bd1554c to 53c38b4 Compare September 30, 2022 14:09

samueljlieber requested a review from meng-odoo September 30, 2022 14:10

meng-odoo approved these changes Sep 30, 2022

View reviewed changes

meng-odoo requested a review from mivu-odoo September 30, 2022 17:29

mivu-odoo suggested changes Oct 3, 2022

View reviewed changes

samueljlieber force-pushed the 14.0-crm-lead-mining-vpk-2 branch from 53c38b4 to d2b1f70 Compare October 4, 2022 19:33

samueljlieber requested a review from mivu-odoo October 4, 2022 19:34

mivu-odoo approved these changes Oct 4, 2022

View reviewed changes

content/applications/sales/crm/acquire_leads/lead_mining.rst Outdated Show resolved Hide resolved

samueljlieber force-pushed the 14.0-crm-lead-mining-vpk-2 branch from d2b1f70 to baf8fc1 Compare October 7, 2022 13:14

StraubCreative commented Dec 5, 2022

View reviewed changes

StraubCreative force-pushed the 14.0-crm-lead-mining-vpk-2 branch from baf8fc1 to 4af536d Compare December 5, 2022 22:23

StraubCreative requested a review from a team December 5, 2022 22:27

AntoineVDV approved these changes Dec 6, 2022

View reviewed changes

robodoo temporarily deployed to merge December 6, 2022 15:54 Inactive

robodoo closed this Dec 6, 2022

	information about the General Data Protection Regulation on `Odoo GDPR <http://odoo.com/gdpr>`__.
	information about the General Data Protection Regulation on `Odoo GDPR <http://odoo.com/gdpr>`_.

		See here for full pricing information: `Lead Generation by Odoo IAP <https://iap.odoo.com/iap/
		in-app-services/167?>`__.

[IMP] CRM: updating flow and screenshots about lead mining #2535

[IMP] CRM: updating flow and screenshots about lead mining #2535

Uh oh!

Conversation

StraubCreative commented Jul 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Jul 31, 2022

Uh oh!

StraubCreative commented Jul 31, 2022

Uh oh!

StraubCreative commented Sep 23, 2022

Uh oh!

meng-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samueljlieber commented Sep 28, 2022

Uh oh!

meng-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

samueljlieber commented Sep 29, 2022

Uh oh!

meng-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samueljlieber commented Sep 30, 2022

Uh oh!

meng-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samueljlieber commented Oct 4, 2022

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samueljlieber commented Oct 7, 2022

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

StraubCreative Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

StraubCreative Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

StraubCreative commented Dec 5, 2022

Uh oh!

StraubCreative commented Dec 5, 2022

Uh oh!

AntoineVDV left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

StraubCreative commented Jul 31, 2022 •

edited

Loading