[IMP] mail plugins: gmail plugin updates #2773

meng-odoo · 2022-09-29T22:31:49Z

Updated to reflect how to download Gmail Plugin from Google Workspace Marketplace for Odoo Online users; added new images

Closes Odoo Task 3001713

robodoo · 2022-09-29T22:32:08Z

Pull request status dashboard.

mivu-odoo

Hello @meng-odoo!

Great job on your first PR! I went through it and found some edits that need to be made to remove the use of second-person pronouns (you, yours), as well sentences that could use transition words for better flow.

I also noticed two image files were quite large gh-download-zip.png and google-workspace-marketplace.png. I think they can be ran through pngquant (if you haven't already) to compress them further. I can show you how to remove the old image files and replace them with the new, compressed versions if you would like, just let me know!

When you finish the revisions, please tag me again for another look. Thank you 😸

content/applications/productivity/mail_plugins/gmail.rst

mivu-odoo

Hi @meng-odoo!

One more round of revisions, we're almost there!

These suggestions have to do with line breaks. Some lines were broken a little too late (over 100 characters) or a little too early (under 100 characters, where more words could've fit on the line). When you're ready, tag me in for a final look. Thank you 😸

content/applications/productivity/mail_plugins/gmail.rst

mivu-odoo

Hello @meng-odoo!

Thank you for the revisions! You did a great job on this PR!

I found two small edits, so feel free to push those and then go straight to tagging ZST for final technical review, no need to tag me again. Thank you 😸

content/applications/productivity/mail_plugins/gmail.rst

meng-odoo · 2022-10-06T21:26:45Z

Thank you @mivu-odoo!
Hi @StraubCreative, this doc is ready for your technical review. Thanks :)

StraubCreative

Hi @meng-odoo 🙂
Change requests below, with instructions.
Thanks!

cc: @mivu-odoo

StraubCreative · 2022-11-19T00:09:00Z

content/applications/productivity/mail_plugins/gmail.rst

+=================

-.. _mail-plugin/gmail/enable-mail-plugin:
+For databases hosted on Odoo Online (or Odoo.sh), follow the steps below to configure the Gmail 


Trailing whitespace

Suggested change

For databases hosted on Odoo Online (or Odoo.sh), follow the steps below to configure the Gmail

For databases hosted on Odoo Online (or Odoo.sh), follow the steps below to configure the Gmail

StraubCreative · 2022-11-19T00:10:10Z

content/applications/productivity/mail_plugins/gmail.rst

+Finally, click :guilabel:`Allow` to let Gmail access the Odoo database. The browser will then show a
+:guilabel:`Success!` message. After that, close the window. The Gmail inbox and Odoo database are


Line break before or at 100th char.

Suggested change

Finally, click :guilabel:`Allow` to let Gmail access the Odoo database. The browser will then show a

:guilabel:`Success!` message. After that, close the window. The Gmail inbox and Odoo database are

Finally, click :guilabel:`Allow` to let Gmail access the Odoo database. The browser will then show

a :guilabel:`Success!` message. After that, close the window. The Gmail inbox and Odoo database are

StraubCreative · 2022-11-19T00:11:08Z

content/applications/productivity/mail_plugins/gmail.rst

+   ensuring, for example, that no add-on redirects users toward a malicious website. (Read more on
+   `Google Apps Script <https://developers.google.com/apps-script/manifest/allowlist-url>`_.)
+
+   Since Odoo can only list the `odoo.com` domain and not every on-premise customer’s unique server


Use sans-serif apostrophe (not the serif version that gets c/p'd over from gdocs or similar text editors).

Suggested change

Since Odoo can only list the `odoo.com` domain and not every on-premise customer’s unique server

Since Odoo can only list the `odoo.com` domain and not every on-premise customer's unique server

StraubCreative · 2022-11-19T00:12:04Z

content/applications/productivity/mail_plugins/gmail.rst

+Finally, click :guilabel:`Allow` to let Gmail access the Odoo database. The browser will then show a
+:guilabel:`Success!` message. After that, close the window. The Gmail inbox and Odoo database are


Line break before or at 100th char

Suggested change

Finally, click :guilabel:`Allow` to let Gmail access the Odoo database. The browser will then show a

:guilabel:`Success!` message. After that, close the window. The Gmail inbox and Odoo database are

Finally, click :guilabel:`Allow` to let Gmail access the Odoo database. The browser will then show

a :guilabel:`Success!` message. After that, close the window. The Gmail inbox and Odoo database are

StraubCreative · 2022-11-19T00:12:31Z

content/applications/productivity/mail_plugins/gmail.rst

-      :alt: Allowing the Gmail Plugin to connect to a database
+Finally, click :guilabel:`Allow` to let Gmail access the Odoo database. The browser will then show a
+:guilabel:`Success!` message. After that, close the window. The Gmail inbox and Odoo database are
+now connected.


Add empty line break at end of doc

Suggested change

now connected.

now connected.

StraubCreative · 2022-11-21T19:17:10Z

content/applications/productivity/mail_plugins/gmail.rst

+such as Notepad (Windows), TextEdit (Mac), or Visual Studio Code.

-.. _mail-plugin/gmail/configure-mailbox:
+Delete the following three lines of text from the :guilabel:`login` TS file:


Use :file: tag here:

Suggested change

Delete the following three lines of text from the :guilabel:`login` TS file:

Delete the following three lines of text from the :file:`login.ts` file:

StraubCreative · 2022-11-21T19:17:36Z

content/applications/productivity/mail_plugins/gmail.rst

-      :align: center
-      :alt: Installing the Gmail Plugin from the Apps Script project
+Open the ZIP file on the computer. Then, go to :menuselection:`mail-client-extensions-master -->
+gmail --> src --> views`, and open the :guilabel:`login` TS file using any text editor software,


Use :file: tag here:

Suggested change

gmail --> src --> views`, and open the :guilabel:`login` TS file using any text editor software,

gmail --> src --> views`, and open the :file:`login.ts` file using any text editor software,

StraubCreative · 2022-11-21T19:22:55Z

content/applications/productivity/mail_plugins/gmail.rst

+to download the Mail Plugin files onto your computer.

-#. Allow the Gmail Plugin to access some of your data.
+.. image:: gmail/gh-download-zip.png


Unresolving. This file is still too big.

StraubCreative · 2022-11-21T19:23:32Z

content/applications/productivity/mail_plugins/gmail.rst


-Install the Gmail Plugin
------------------------
+.. image:: gmail/google-workspace-marketplace.png


Unresolving. This image is still too big.

StraubCreative · 2022-11-21T19:28:05Z

content/applications/productivity/mail_plugins/gmail.rst


-Install the Gmail Plugin
------------------------
+.. image:: gmail/gmail-side-panel.png


This image is too big.

Capture screenshot in HD (browser at ~1280x600px with ~120% zoom)

Resize file to tablet/low-res desktop breakpoint b/w 768 and ~1024px (lowest you can go without having to squint at the content).

Compress file using pngquant

Replace file locally using git rm and git add

meng-odoo · 2022-12-01T21:48:01Z

Hi @StraubCreative, I made all your requested changes. I'm still getting a failed code check that says "trailing whitespace" but I double checked every line and I don't see it. Please let me know if I should make any more changes. Thanks!

StraubCreative

Thanks for making all of the changes @meng-odoo, nice job 👍
Everything looks good to me.

I combed for whitespaces and did another rebase on 4625793, but still couldn't the issue the CI check error, so I'm going to push to DR and maybe they can help.

StraubCreative · 2022-12-05T18:32:19Z

Hi @odoo/doc-review 👋
This PR is ready for review.
Please advise we couldn't find the trailing whitespace the CI check claimed was there.
We combed it twice and rebased twice as well. Can you help? TIA 🙏

Updated to reflect how to download Gmail Plugin from Google Workspace Marketplace for Odoo Online users; added new images Closes Odoo Task 3001713

Feyensv · 2022-12-06T11:14:20Z

Hi @odoo/doc-review wave This PR is ready for review. Please advise we couldn't find the trailing whitespace the CI check claimed was there. We combed it twice and rebased twice as well. Can you help?

It means that there was some empty spaces left in your changes, though it's difficult to see unless you have a dedicated extension in your text editor:

I've removed those empty spaces and pushed an updated commit.

Note that the CI check was supposed to give the correct line where the linting error was found, which wasn't the case here, it only showed 8 instead of 88, we'll see with the runbot team to make sure it's correctly shown in the future ;).

Feyensv

@robodoo r+

Updated to reflect how to download Gmail Plugin from Google Workspace Marketplace for Odoo Online users; added new images Closes Odoo Task 3001713 closes #2773 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

meng-odoo requested a review from mivu-odoo September 29, 2022 22:31

meng-odoo self-assigned this Sep 29, 2022

C3POdoo requested a review from a team September 29, 2022 22:33

mivu-odoo suggested changes Oct 3, 2022

View reviewed changes

meng-odoo force-pushed the 15.0-gmail-plugin-updates-meng branch 2 times, most recently from 3a6abe3 to 45f310d Compare October 5, 2022 19:46

meng-odoo requested a review from mivu-odoo October 5, 2022 19:49

mivu-odoo suggested changes Oct 5, 2022

View reviewed changes

meng-odoo force-pushed the 15.0-gmail-plugin-updates-meng branch from 45f310d to 8b9f164 Compare October 5, 2022 23:32

meng-odoo requested a review from mivu-odoo October 5, 2022 23:37

mivu-odoo approved these changes Oct 6, 2022

View reviewed changes

content/applications/productivity/mail_plugins/gmail.rst Outdated Show resolved Hide resolved

content/applications/productivity/mail_plugins/gmail.rst Outdated Show resolved Hide resolved

meng-odoo force-pushed the 15.0-gmail-plugin-updates-meng branch from 8b9f164 to 1ca6a19 Compare October 6, 2022 21:24

meng-odoo requested a review from StraubCreative October 6, 2022 21:25

StraubCreative requested changes Nov 21, 2022

View reviewed changes

meng-odoo force-pushed the 15.0-gmail-plugin-updates-meng branch 2 times, most recently from c735f56 to e01e6ce Compare December 1, 2022 21:28

StraubCreative force-pushed the 15.0-gmail-plugin-updates-meng branch from e01e6ce to 4625793 Compare December 5, 2022 18:21

StraubCreative approved these changes Dec 5, 2022

View reviewed changes

StraubCreative requested a review from a team December 5, 2022 18:32

[IMP] mail plugins: gmail plugin updates

f8ea2cb

Updated to reflect how to download Gmail Plugin from Google Workspace Marketplace for Odoo Online users; added new images Closes Odoo Task 3001713

Feyensv force-pushed the 15.0-gmail-plugin-updates-meng branch from 4625793 to f8ea2cb Compare December 6, 2022 11:12

Feyensv approved these changes Dec 6, 2022

View reviewed changes

fw-bot mentioned this pull request Dec 6, 2022

[FW][IMP] mail plugins: gmail plugin updates #3108

Closed

robodoo temporarily deployed to merge December 6, 2022 14:02 Inactive

robodoo closed this Dec 6, 2022

This was referenced Dec 6, 2022

[FW][IMP] mail plugins: gmail plugin updates #3109

Closed

[FW][IMP] mail plugins: gmail plugin updates #3110

Closed

[FW][IMP] mail plugins: gmail plugin updates #3111

Closed

Feyensv deleted the 15.0-gmail-plugin-updates-meng branch October 17, 2025 16:39

	For databases hosted on Odoo Online (or Odoo.sh), follow the steps below to configure the Gmail
	For databases hosted on Odoo Online (or Odoo.sh), follow the steps below to configure the Gmail

		Finally, click :guilabel:`Allow` to let Gmail access the Odoo database. The browser will then show a
		:guilabel:`Success!` message. After that, close the window. The Gmail inbox and Odoo database are

	Since Odoo can only list the `odoo.com` domain and not every on-premise customer’s unique server
	Since Odoo can only list the `odoo.com` domain and not every on-premise customer's unique server

	Delete the following three lines of text from the :guilabel:`login` TS file:
	Delete the following three lines of text from the :file:`login.ts` file:

	gmail --> src --> views`, and open the :guilabel:`login` TS file using any text editor software,
	gmail --> src --> views`, and open the :file:`login.ts` file using any text editor software,

[IMP] mail plugins: gmail plugin updates #2773

[IMP] mail plugins: gmail plugin updates #2773

Uh oh!

Conversation

meng-odoo commented Sep 29, 2022

Uh oh!

robodoo commented Sep 29, 2022

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mivu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

meng-odoo commented Oct 6, 2022

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meng-odoo commented Dec 1, 2022

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

StraubCreative commented Dec 5, 2022

Uh oh!

Feyensv commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Feyensv left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Feyensv commented Dec 6, 2022 •

edited

Loading