-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] website: mail groups #6048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5df13d0 to
bfe42bf
Compare
bfe42bf to
741bf69
Compare
741bf69 to
f2c861e
Compare
toaa-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @auva-odoo, great work! I only moved a line, the rest was all good :)
xpl-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @auva-odoo ! Almost all comments are nitpicks, as usual ;)
Note: do we really want to have this page at the level of the Pages/Configuration etc. sections? It feels like we give this feature too much importance maybe?
task-2845181
f2c861e to
14621a3
Compare
|
Hey @xpl-odoo thank you for the review! I implemented all of the suggested changes, except the one regarding weather we really want to have this page at the level of the Pages/Configuration etc. sections? I would argue that although I see your point, it's the solution that makes the most sense to me at this time. We can discuss this if you want :-) |
No need to discuss this, we can @robodoo r+ :) |
|
@robodoo r+ |
task-2845181 closes #6048 Signed-off-by: Xavier Platteau (xpl) <xpl@odoo.com>
task-2845181