Skip to content

Conversation

@auva-odoo
Copy link
Contributor

task-2845181

@robodoo
Copy link
Collaborator

robodoo commented Oct 6, 2023

@auva-odoo auva-odoo force-pushed the 15.0-website-mailing-lists-auva branch 2 times, most recently from 5df13d0 to bfe42bf Compare October 12, 2023 05:37
@auva-odoo auva-odoo changed the title [ADD] website: mailing lists [ADD] website: mail groups Oct 12, 2023
@auva-odoo auva-odoo marked this pull request as ready for review October 12, 2023 05:38
@C3POdoo C3POdoo requested a review from a team October 12, 2023 05:39
@auva-odoo auva-odoo force-pushed the 15.0-website-mailing-lists-auva branch from bfe42bf to 741bf69 Compare October 12, 2023 05:40
@auva-odoo auva-odoo requested a review from toaa-odoo October 12, 2023 06:46
@toaa-odoo toaa-odoo force-pushed the 15.0-website-mailing-lists-auva branch from 741bf69 to f2c861e Compare October 12, 2023 07:51
Copy link
Contributor

@toaa-odoo toaa-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @auva-odoo, great work! I only moved a line, the rest was all good :)

@toaa-odoo toaa-odoo requested a review from a team October 12, 2023 07:53
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @auva-odoo ! Almost all comments are nitpicks, as usual ;)

Note: do we really want to have this page at the level of the Pages/Configuration etc. sections? It feels like we give this feature too much importance maybe?

@auva-odoo auva-odoo force-pushed the 15.0-website-mailing-lists-auva branch from f2c861e to 14621a3 Compare November 27, 2023 14:11
@auva-odoo
Copy link
Contributor Author

Hey @xpl-odoo thank you for the review! I implemented all of the suggested changes, except the one regarding weather we really want to have this page at the level of the Pages/Configuration etc. sections? I would argue that although I see your point, it's the solution that makes the most sense to me at this time. We can discuss this if you want :-)

@xpl-odoo
Copy link
Contributor

Hey @xpl-odoo thank you for the review! I implemented all of the suggested changes, except the one regarding weather we really want to have this page at the level of the Pages/Configuration etc. sections? I would argue that although I see your point, it's the solution that makes the most sense to me at this time. We can discuss this if you want :-)

No need to discuss this, we can @robodoo r+ :)

@xpl-odoo xpl-odoo closed this Nov 28, 2023
@xpl-odoo xpl-odoo reopened this Nov 28, 2023
@xpl-odoo
Copy link
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants