From 0ab1bb6417af1fc7a80030f7c679121dfd3a00ab Mon Sep 17 00:00:00 2001 From: "Antoine Vandevenne (anv)" Date: Mon, 12 Aug 2024 16:01:34 +0000 Subject: [PATCH] [FIX] reference/view_architectures: remove outdated and broken link The external link to `AbstractController` class was broken, both because the placeholder substitution mechanism doesn't work in included RST excerpts and because the class has long been removed. Since it makes little sense to replace the link with another link to the `useActionLinks` hook in the context of this reference doc, this commit removes the link altogether, as well as the erroneous mention of class limitations. X-original-commit: e7d2be636672074a87f6e14de828ce9620acea0e --- conf.py | 3 +++ .../view_architectures/root_attribute_banner_route.rst | 9 ++------- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/conf.py b/conf.py index ab3e2b0710..03feb524bd 100644 --- a/conf.py +++ b/conf.py @@ -391,6 +391,9 @@ def setup(app): app.add_config_value('is_remote_build', None, 'env') # Whether the build is remotely deployed app.add_config_value('source_read_replace_vals', {}, 'env') app.connect('source-read', source_read_replace) + # TODO uncomment after moving to >= v7.2.5 to also substitute placeholders in included files. + # See https://github.com/sphinx-doc/sphinx/commit/ff1831 + # app.connect('include-read', source_read_replace) app.add_lexer('json', JsonLexer) app.add_lexer('xml', XmlLexer) diff --git a/content/developer/reference/user_interface/view_architectures/root_attribute_banner_route.rst b/content/developer/reference/user_interface/view_architectures/root_attribute_banner_route.rst index 5e96dca09d..9c7e3a568c 100644 --- a/content/developer/reference/user_interface/view_architectures/root_attribute_banner_route.rst +++ b/content/developer/reference/user_interface/view_architectures/root_attribute_banner_route.rst @@ -10,13 +10,8 @@ If the HTML contains a `` tag for a stylesheet, it is removed from its original location and appended to the `` section. - To interact with the backend, use `` tags. For more details, refer to the - documentation of the `_onActionClicked` method in `AbstractController - <{GITHUB_PATH}/addons/web/static/src/js/views/abstract_controller.js>`_. - - Only views extending `AbstractView` and `AbstractController`, such as - :ref:`reference/view_architectures/form`, :ref:`reference/view_architectures/kanban`, and - :ref:`reference/view_architectures/list`, can use this attribute. + Use `` tags to interact with the backend, like with :ref:`action buttons + `. .. example:: .. code-block:: xml