[IMP] developer: review calendar date_stop/date_delay definitions #15439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
qsm-odoo
force-pushed
the
master-calendar-domain-qsm
branch
from
5cecbf1 to
322cb79
Compare
aab-odoo
approved these changes
Nov 25, 2025
AntoineVDV
approved these changes
Nov 25, 2025
Collaborator
AntoineVDV
left a comment
AntoineVDV
left a comment
There was a problem hiding this comment.
@robodoo r+ delegate+
Collaborator
|
@qsm-odoo @AntoineVDV linked pull request(s) odoo/odoo#237283 not ready. Linked PRs are not staged until all of them are ready. |
qsm-odoo
force-pushed
the
master-calendar-domain-qsm
branch
2 times, most recently
from
9dbb95c to
b1ceb4b
Compare
The `date_delay` option was removed in [1] but the documentation still mentioned it. Also reviewed the default value of `date_stop`. [1]: odoo/odoo@40c75d3 Related to task-5350495
qsm-odoo
force-pushed
the
master-calendar-domain-qsm
branch
from
b1ceb4b to
d199c4d
Compare
qsm-odoo
commented
Nov 27, 2025
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Nov 28, 2025
Related to task-5350495 Part-of: #237283 Related: odoo/enterprise#100501 Related: odoo/documentation#15439 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Nov 28, 2025
When a calendar view was defined with both a start and stop date fields, only records having both fields set were shown. This commit improves that by also showing records whose start date are within range, even if their stop date is not (yet?) set. Note: [1] removed the `date_delay` calendar option and changed the behavior of not adding `date_stop`. This commit clarifies that part in the code as well. [1]: 40c75d3 Related to task-5350495 closes #237283 Related: odoo/enterprise#100501 Related: odoo/documentation#15439 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Nov 28, 2025
The `date_delay` option was removed in [1] but the documentation still mentioned it. Also reviewed the default value of `date_stop`. [1]: odoo/odoo@40c75d3 Related to task-5350495 closes #15439 Related: odoo/odoo#237283 Related: odoo/enterprise#100501 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Nov 28, 2025
Related to task-5350495 Part-of: #237283 Related: odoo/enterprise#100501 Related: odoo/documentation#15439 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Nov 28, 2025
When a calendar view was defined with both a start and stop date fields, only records having both fields set were shown. This commit improves that by also showing records whose start date are within range, even if their stop date is not (yet?) set. Note: [1] removed the `date_delay` calendar option and changed the behavior of not adding `date_stop`. This commit clarifies that part in the code as well. [1]: 40c75d3 Related to task-5350495 closes #237283 Related: odoo/enterprise#100501 Related: odoo/documentation#15439 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Nov 28, 2025
The `date_delay` option was removed in [1] but the documentation still mentioned it. Also reviewed the default value of `date_stop`. [1]: odoo/odoo@40c75d3 Related to task-5350495 closes #15439 Related: odoo/odoo#237283 Related: odoo/enterprise#100501 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
kmdi-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 1, 2025
Related to task-5350495 Part-of: odoo#237283 Related: odoo/enterprise#100501 Related: odoo/documentation#15439 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
kmdi-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 1, 2025
When a calendar view was defined with both a start and stop date fields, only records having both fields set were shown. This commit improves that by also showing records whose start date are within range, even if their stop date is not (yet?) set. Note: [1] removed the `date_delay` calendar option and changed the behavior of not adding `date_stop`. This commit clarifies that part in the code as well. [1]: odoo@40c75d3 Related to task-5350495 closes odoo#237283 Related: odoo/enterprise#100501 Related: odoo/documentation#15439 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
date_delayoption was removed in 1 but the documentation still mentioned it. Also reviewed the default value ofdate_stop.Related to task-5350495