Skip to content

Conversation

@theRealThagomizer
Copy link
Contributor

Hiya, @meval1006! I've got a brand new page that explains how alternative products on a product form work and how to configure them. This PR is a spin-off of #15588, which was similar, but for optional products instead of alternative ones.

Thanks for the review!

@robodoo
Copy link
Collaborator

robodoo commented Dec 8, 2025

Pull request status dashboard

@theRealThagomizer
Copy link
Contributor Author

Bluh. I clocked the missing newline at the end of the file and have already saved it locally.

@C3POdoo C3POdoo requested a review from a team December 8, 2025 21:45
Copy link
Contributor

@meval1006 meval1006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas, good job on the new content. I added some minor edits. Feel free to let me know if you need me to give more context on any of my feedback.

Products` and choose a product. Ensure that the product's :guilabel:`Sales` checkbox is checked and
click the :guilabel:`Sales` tab. Under :guilabel:`UPSELL & CROSS-SELL` section, the
:guilabel:`Alternative Products` drop-down menu allows for alternative products to be set. Products
will be displayed in alphabetical order. If the desired product isn't readily visible, type its name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
will be displayed in alphabetical order. If the desired product isn't readily visible, type its name
are displayed in alphabetical order. If the desired product isn't readily visible, type its name

visits the webpage for an associated core product.

.. image:: alternative_products/product-form-alternative-products.png
:alt: The alternative product field on the product form
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky, but I usually use sentence punctuation for the image alt descriptions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to file this one under "let's settle on a team-wide answer at the style meeting on Wednesday" for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with Felicia and she confirmed it is a current style guide rule. It's just that our linter is broken.

Comment on lines 5 to 6
The use of alternative products is a marketing strategy that involves the upselling of useful and
related products alongside a desired core product. For instance, by configuring alternative
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The use of alternative products is a marketing strategy that involves the upselling of useful and
related products alongside a desired core product. For instance, by configuring alternative
The use of alternative products is a marketing strategy that involves upselling related products alongside a desired core product. For instance, by configuring alternative

:alt: Alternative products as they appear on an eCommerce website

.. note::
Alternative products are differentiated from accessory products and optional products by where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Alternative products are differentiated from accessory products and optional products by where
Alternative products are different from accessory and optional products because of where


.. note::
Alternative products are differentiated from accessory products and optional products by where
they appear in the customer's shopping experience.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
they appear in the customer's shopping experience.
they show up in the customer's shopping journey.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a semi-interesting conversation to be had here about what's less jargon-y, a shopping journey or a shopping experience. Leaving this as-is for now in anticipation of bringing this up in the style meeting.


To add an alternative product to a product form, navigate to :menuselection:`Sales --> Products -->
Products` and choose a product. Ensure that the product's :guilabel:`Sales` checkbox is checked and
click the :guilabel:`Sales` tab. Under :guilabel:`UPSELL & CROSS-SELL` section, the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
click the :guilabel:`Sales` tab. Under :guilabel:`UPSELL & CROSS-SELL` section, the
click the :guilabel:`Sales` tab. In the :guilabel:`UPSELL & CROSS-SELL` section, click the

To add an alternative product to a product form, navigate to :menuselection:`Sales --> Products -->
Products` and choose a product. Ensure that the product's :guilabel:`Sales` checkbox is checked and
click the :guilabel:`Sales` tab. Under :guilabel:`UPSELL & CROSS-SELL` section, the
:guilabel:`Alternative Products` drop-down menu allows for alternative products to be set. Products
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:guilabel:`Alternative Products` drop-down menu allows for alternative products to be set. Products
:guilabel:`Alternative Products` drop-down menu and select the desired products. Products

Comment on lines 43 to 45
the catalog and includes the :guilabel:`New` button to create a new product. Multiple products may
be selected as alternative products at once when using this form by clicking their checkboxes and
then clicking :guilabel:`Select`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the catalog and includes the :guilabel:`New` button to create a new product. Multiple products may
be selected as alternative products at once when using this form by clicking their checkboxes and
then clicking :guilabel:`Select`.
the catalog and includes the :guilabel:`New` button to create a new product. Multiple products can
be selected as alternatives at once in this form by ticking their checkboxes and
then clicking :guilabel:`Select`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky, but if you can make a clean demo with minimal configurations to show what the default app options would look like. For example, you don't need the Rental or Expenses app integration for this feature.

@theRealThagomizer theRealThagomizer force-pushed the 19.0-sales-alternative-products-thjud branch from 01e73f2 to 7f18b9c Compare December 9, 2025 01:57
Copy link
Contributor

@meval1006 meval1006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas, good job. Just two minor edits.

visits the webpage for an associated core product.

.. image:: alternative_products/product-form-alternative-products.png
:alt: The alternative product field on the product form
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with Felicia and she confirmed it is a current style guide rule. It's just that our linter is broken.

Co-authored-by: Megan Valenzuela <meval@odoo.com>
@theRealThagomizer theRealThagomizer force-pushed the 19.0-sales-alternative-products-thjud branch from 7f18b9c to 8a8602c Compare December 9, 2025 02:39
@theRealThagomizer
Copy link
Contributor Author

@Felicious Tihs is ready for your review prior to merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants