-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[ADD] Sales: Created a new alternative products page #15599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
|
Bluh. I clocked the missing newline at the end of the file and have already saved it locally. |
meval1006
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thomas, good job on the new content. I added some minor edits. Feel free to let me know if you need me to give more context on any of my feedback.
| Products` and choose a product. Ensure that the product's :guilabel:`Sales` checkbox is checked and | ||
| click the :guilabel:`Sales` tab. Under :guilabel:`UPSELL & CROSS-SELL` section, the | ||
| :guilabel:`Alternative Products` drop-down menu allows for alternative products to be set. Products | ||
| will be displayed in alphabetical order. If the desired product isn't readily visible, type its name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| will be displayed in alphabetical order. If the desired product isn't readily visible, type its name | |
| are displayed in alphabetical order. If the desired product isn't readily visible, type its name |
| visits the webpage for an associated core product. | ||
|
|
||
| .. image:: alternative_products/product-form-alternative-products.png | ||
| :alt: The alternative product field on the product form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky, but I usually use sentence punctuation for the image alt descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to file this one under "let's settle on a team-wide answer at the style meeting on Wednesday" for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with Felicia and she confirmed it is a current style guide rule. It's just that our linter is broken.
| The use of alternative products is a marketing strategy that involves the upselling of useful and | ||
| related products alongside a desired core product. For instance, by configuring alternative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The use of alternative products is a marketing strategy that involves the upselling of useful and | |
| related products alongside a desired core product. For instance, by configuring alternative | |
| The use of alternative products is a marketing strategy that involves upselling related products alongside a desired core product. For instance, by configuring alternative |
| :alt: Alternative products as they appear on an eCommerce website | ||
|
|
||
| .. note:: | ||
| Alternative products are differentiated from accessory products and optional products by where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Alternative products are differentiated from accessory products and optional products by where | |
| Alternative products are different from accessory and optional products because of where |
|
|
||
| .. note:: | ||
| Alternative products are differentiated from accessory products and optional products by where | ||
| they appear in the customer's shopping experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| they appear in the customer's shopping experience. | |
| they show up in the customer's shopping journey. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a semi-interesting conversation to be had here about what's less jargon-y, a shopping journey or a shopping experience. Leaving this as-is for now in anticipation of bringing this up in the style meeting.
content/applications/sales/sales/products_prices/alternative_products.rst
Show resolved
Hide resolved
|
|
||
| To add an alternative product to a product form, navigate to :menuselection:`Sales --> Products --> | ||
| Products` and choose a product. Ensure that the product's :guilabel:`Sales` checkbox is checked and | ||
| click the :guilabel:`Sales` tab. Under :guilabel:`UPSELL & CROSS-SELL` section, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| click the :guilabel:`Sales` tab. Under :guilabel:`UPSELL & CROSS-SELL` section, the | |
| click the :guilabel:`Sales` tab. In the :guilabel:`UPSELL & CROSS-SELL` section, click the |
| To add an alternative product to a product form, navigate to :menuselection:`Sales --> Products --> | ||
| Products` and choose a product. Ensure that the product's :guilabel:`Sales` checkbox is checked and | ||
| click the :guilabel:`Sales` tab. Under :guilabel:`UPSELL & CROSS-SELL` section, the | ||
| :guilabel:`Alternative Products` drop-down menu allows for alternative products to be set. Products |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :guilabel:`Alternative Products` drop-down menu allows for alternative products to be set. Products | |
| :guilabel:`Alternative Products` drop-down menu and select the desired products. Products |
| the catalog and includes the :guilabel:`New` button to create a new product. Multiple products may | ||
| be selected as alternative products at once when using this form by clicking their checkboxes and | ||
| then clicking :guilabel:`Select`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| the catalog and includes the :guilabel:`New` button to create a new product. Multiple products may | |
| be selected as alternative products at once when using this form by clicking their checkboxes and | |
| then clicking :guilabel:`Select`. | |
| the catalog and includes the :guilabel:`New` button to create a new product. Multiple products can | |
| be selected as alternatives at once in this form by ticking their checkboxes and | |
| then clicking :guilabel:`Select`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky, but if you can make a clean demo with minimal configurations to show what the default app options would look like. For example, you don't need the Rental or Expenses app integration for this feature.
01e73f2 to
7f18b9c
Compare
meval1006
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thomas, good job. Just two minor edits.
| visits the webpage for an associated core product. | ||
|
|
||
| .. image:: alternative_products/product-form-alternative-products.png | ||
| :alt: The alternative product field on the product form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with Felicia and she confirmed it is a current style guide rule. It's just that our linter is broken.
Co-authored-by: Megan Valenzuela <meval@odoo.com>
7f18b9c to
8a8602c
Compare
|
@Felicious Tihs is ready for your review prior to merging! |

Hiya, @meval1006! I've got a brand new page that explains how alternative products on a product form work and how to configure them. This PR is a spin-off of #15588, which was similar, but for optional products instead of alternative ones.
Thanks for the review!