[IMP] accounting: SEPA #2849
Closed
[IMP] accounting: SEPA #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chiaraprattico
force-pushed
the
15.0-sepa-chpr
branch
from
7f5e6e9 to
cee3c0e
Compare
chiaraprattico
requested review from
toaa-odoo
and removed request for
a team
Closed
toaa-odoo
suggested changes
Oct 25, 2022
Contributor
toaa-odoo
left a comment
toaa-odoo
left a comment
There was a problem hiding this comment.
Made a few comments, please have a look :)
chiaraprattico
force-pushed
the
15.0-sepa-chpr
branch
4 times, most recently
from
9382726 to
ebaabf4
Compare
chiaraprattico
requested review from
a team and
toaa-odoo
and removed request for
toaa-odoo
toaa-odoo
force-pushed
the
15.0-sepa-chpr
branch
from
8228438 to
2ba638a
Compare
toaa-odoo
approved these changes
Oct 27, 2022
xpl-odoo
requested changes
Nov 7, 2022
Contributor
xpl-odoo
left a comment
xpl-odoo
left a comment
There was a problem hiding this comment.
Good job Chiara! I would remove the info about SDD from here, and move it under receivables
chiaraprattico
force-pushed
the
15.0-sepa-chpr
branch
4 times, most recently
from
f3392b2 to
69c21b0
Compare
xpl-odoo
approved these changes
Nov 8, 2022
chiaraprattico
force-pushed
the
15.0-sepa-chpr
branch
from
69c21b0 to
2890e78
Compare
AntoineVDV
requested changes
Nov 8, 2022
chiaraprattico
force-pushed
the
15.0-sepa-chpr
branch
2 times, most recently
from
8647c64 to
f3f3028
Compare
Collaborator
|
@robodoo delegate+ @chiaraprattico @xpl-odoo For when you decide what you want to do with that extra section ☝️ |
chiaraprattico
force-pushed
the
15.0-sepa-chpr
branch
from
f3f3028 to
e90c4d5
Compare
Contributor
|
@chiaraprattico since you force-pushed after Antoine's comment, I assume you addressed #2849 (comment) ? Also, as you can see below, there is a conflict now so you will need to rebase first before we can merge the PR. Don't hesitate to ask for help if needed :) |
chiaraprattico
force-pushed
the
15.0-sepa-chpr
branch
from
e90c4d5 to
a9b99fe
Compare
chiaraprattico
force-pushed
the
15.0-sepa-chpr
branch
2 times, most recently
from
873f085 to
6bfe2a0
Compare
taskid: 2890089
xpl-odoo
force-pushed
the
15.0-sepa-chpr
branch
from
6bfe2a0 to
ae35d10
Compare
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 5, 2022
closes #2849 Taskid: 2890089 Signed-off-by: Platteau Xavier (xpl) <xpl@odoo.com>
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taskid: 2890089