[ADD] inventory: setup sendcloud shipping

[samueljlieber]

Task: #3010897

[robodoo]

Pull request status dashboard.

[tiku-odoo]

@mivu-odoo This doc for Sendcloud configuration Odoo 16 is ready for your final review when you have a moment. Thanks, Tim :)

[mivu-odoo]

Hello @tiku-odoo and @samueljlieber!

I had a few questions on capitalizations of field labels that @tiku-odoo will need to double-check, if possible. Once confirmed and the changes are applied, please tag me again for another look. Thank you 😸

[tiku-odoo]

@mivu-odoo

This document is ready for your review. I'd like to remove lines 40-41. I look forward to any changes you'd like to make. Thanks in advance for reviewing this doc!

[mivu-odoo]

Hello @samueljlieber and @tiku-odoo!

Thank you for revising the PR based on my comments! I left a couple of small comments on spacing/line breaks and :guilabel:'s. I agree with @tiku-odoo that the .. note:: on Lines 40-41 can be deleted.

Feel free to make those revisions and go straight to ZST for final technical review.

Thank you 😸

[samueljlieber]

Hi @StraubCreative! This doc is ready for a final technical review! 🙂

[tiku-odoo]

@StraubCreative Hi Zac, Thomas has a quick edit for this doc that I'm going to add on regarding the return labels. Please hold off on this review for now until I make the update. Thanks for your flexibility.

[tiku-odoo]

@mivu-odoo There is another update from Thomas on this PR. I've added in lines 160-162. Can you proof-read and push to final review? Thanks for reviewing again :)

[mivu-odoo]

Hi @tiku-odoo!

I made a small edit for the new content on Lines 160-162. Once you push the edit, feel free to tag ZST again for final technical review!

[tiku-odoo]

@StraubCreative This document is ready for your technical review. Whenever you have a moment can you take a look? Thanks in advance for your help on this! 👍

[StraubCreative]

Kicking back to @mivu-odoo for second content review.
If you run into merge conflict on your revisions bc of #2983 let me or @samueljlieber know.

[mivu-odoo]

Hi @tiku-odoo!

A couple of edits needed. Please tag me for a second look when you're ready. Thank you 😸

[tiku-odoo]

@mivu-odoo I've made the requested changes; it's ready for your review again. Thanks for your help on this doc. Have a good evening! 👍

[mivu-odoo]

Hello @tiku-odoo!

Thank you for the quick edits! I found a couple more lines that needed edits. Please tag me again when you're ready. Thank you 😸

[tiku-odoo]

@mivu-odoo

Thanks for your changes! 💯

I've pushed the changes you requested and made a minor edit to line 91, where the module was said to be "activated" instead of "installed" first. I've changed both "activated" references in the last sentence on line 91 to state "install." After the installation, the connector needs to be activated, which we state in the following section.

👍

[tiku-odoo]

@mivu-odoo I've incorporated the edits from Thomas (thd) into this Sendcloud PR.

This document is ready for another review! 👍

Edited lines:
Lines:
41-44 - edited

78-79 - edited to say Odoo Native

Removed lines 83-84 (no longer in PR)

Added Lines 221-227

When you have a moment, can you review these changes?

Thank you!

Tim

[mivu-odoo]

Hello @tiku-odoo!

I'm approving with just one comment. Once you push the edit, please tag ZST directly for a final technical review. Thank you 😸

[samueljlieber]

Updates in 37f9e71:

• @mivu-odoo's suggestion
• Corrected a couple instances of where 'Sendcloud' was pascal cased (i.e. SendCloud)

@StraubCreative ready for your technical review!

cc. @tiku-odoo

[StraubCreative]

Hi @tiku-odoo

I'm pausing technical review for the moment as there are some content issues that need to be addressed first.

@samueljlieber let's connect on the example tags and see if there's a better way we can structure those with or without images.

@mivu-odoo can you give this another pass-through please? We can trim a bunch of unnecessary words/sentences I think and I could use a second opinion about the example tag usage 🙏 It's a new tag for us as a team so maybe we can try to define a convention of when/how to use it?

[samueljlieber]

bb2e256 for example block changes, still need to make the remaining changes from @StraubCreative.

[tiku-odoo]

@mivu-odoo This doc is ready for your review again when you have a moment.

See above comments from Zac (zst): #2864 (review)

Thanks for your review 👍

[StraubCreative]

Hi @tiku-odoo
Change requests and suggestions below for content.
Let's knock these out and I can give it another look 👍

[tiku-odoo]

Thanks, @StraubCreative, for the review and recommending changes. I've made the requested changes and understand where you're coming from. I've also added GUI-labels to the examples.

This document is ready for another final review when you have some time. Thanks in advance for your help on this Sendcloud doc 💯 👍

[StraubCreative]

Hi @tiku-odoo

We're at the finish line 🚀

I've added some final considerations below, mostly around the formatting of the example tags which included a few formatting items we'd have to address anyway.

Please see the second commit 635cad7 that I attached to the PR to view the updates using Make.

Instructions:

• git checkout 16.0-inventory-sendcloud-shipping-connector-tiku
• git pull --rebase
• git log --> the HEAD should be at 635cad7. If not, do git checkout 635cad7.
• make html and view the changes in a browser.

If you agree with the changes I made, then I can squash the commits, push back up and ship to DR.

Thanks and let me know!

cc: @samueljlieber

[StraubCreative]

This section still isn't quite right.

• removed colons : from sub-section headings (not needed imo)
• labeled field data with backticks
• touched up the psuedo-note at the end for clarity.

Here's are before and after screenshots to visually show the difference.

Suggested change

	.. example::
	| **SendClould configuration:**
	| :guilabel:`Miscellaneous`
	| :guilabel:`Address Name (optional)` - **Warehouse #1**
	| :guilabel:`Brand` - Default
	| **Odoo warehouse configuration:**
	| :guilabel:`Warehouse` - **Warehouse #1**
	| :guilabel:`Short Name` - WH
	| :guilabel:`Company` - My company (San Francisco)
	| :guilabel:`Address` - My Company (San Francisco)
	Notice how the name for both the Odoo configuration and the Sendcloud configuration are the exact
	same.
	.. example::
	| **SendClould configuration**
	| :guilabel:`Miscellaneous`
	| :guilabel:`Address Name (optional)`: `Warehouse #1`
	| :guilabel:`Brand`: `Default`
	| **Odoo warehouse configuration**
	| :guilabel:`Warehouse`: `Warehouse #1`
	| :guilabel:`Short Name`: `WH`
	| :guilabel:`Company`: `My company (San Francisco)`
	| :guilabel:`Address`: `My Company (San Francisco)`
	Notice how the inputs for the :guilabel:`Warehouse` field, for both the Odoo configuration and
	the Sendcloud configuration, are the exact same.

[StraubCreative]

100th char break

Suggested change

	completing the account setup, activate (or deactivate) the shipping carriers that will be used in
	the Odoo database.
	completing the account setup, activate (or deactivate) the shipping carriers that will be used
	in the Odoo database.

[StraubCreative]

Same here— would format everything like previous example tag.
Notice the guilabel formatting for DELIVERY and RETURN as this is how it shows up on the GUI.

Suggested change

	.. example::
	Sample Sendcloud shipping products configured in Odoo:
	| **Delivery:**
	| :guilabel:`Shipping Product` - DPD Home 0-31.5kg
	| :guilabel:`Carrier` - DPD
	| :guilabel:`Minimum Weight` - 0.00
	| :guilabel:`Maximum Weight` - 31.50
	:guilabel:`Countries` - Austria, Belgium, Bosnia and Herzegovina, Bulgaria, Croatia, Czech
	Republic, Denmark, Estonia, Finland, France, Germany, Greece, Hungary, Iceland, Ireland, Italy,
	Latvia, Liechtenstein, Lithuania, Luxembourg, Monaco, Netherlands, Norway, Poland, Portugal,
	Romania, Serbia, Slovakia, Slovenia, Spain, Sweden, Switzerland
	| **Return:**
	| :guilabel:`Return Shipping Product`- DPD Return 0-20kg
	| :guilabel:`Return Carrier` - DPD
	| :guilabel:`Return Minimum Weight` - 0.00
	| :guilabel:`Return Minimum Weight` - 20.00
	| :guilabel:`Return Countries` - Belgium, Netherlands
	.. example::
	Sample Sendcloud shipping products configured in Odoo:
	| :guilabel:`DELIVERY`
	| :guilabel:`Shipping Product`: `DPD Home 0-31.5kg`
	| :guilabel:`Carrier`: `DPD`
	| :guilabel:`Minimum Weight`: `0.00`
	| :guilabel:`Maximum Weight`: `31.50`
	:guilabel:`Countries`: `Austria` `Belgium` `Bosnia` `Herzegovina` `Bulgaria` `Croatia` `Czech`
	`Republic` `Denmark` `Estonia` `Finland` `France` `Germany` `Greece` `Hungary` `Iceland`
	`Ireland` `Italy` `Latvia` `Liechtenstein` `Lithuania` `Luxembourg` `Monaco` `Netherlands`
	`Norway` `Poland` `Portugal` `Romania` `Serbia` `Slovakia` `Slovenia` `Spain` `Sweden`
	`Switzerland`
	| :guilabel:`RETURN`
	| :guilabel:`Return Shipping Product`: `DPD Return 0-20kg`
	| :guilabel:`Return Carrier`: `DPD`
	| :guilabel:`Return Minimum Weight`: `0.00`
	| :guilabel:`Return Minimum Weight`: `20.00`
	| :guilabel:`Return Countries`: `Belgium` `Netherlands`

[tiku-odoo]

@StraubCreative
CC: @samueljlieber

The changes in this commit look great! The examples are really clear now. Thanks for making the changes 👍

635cad7

This commit is good to push up and send to DR.

Thanks for all your work on this. Looking forward to seeing it published.

👍

[StraubCreative]

This doc on sendcloud shipping is good for your review @odoo/doc-review 🚀
Thanks in advance!

[AntoineVDV]

💯

@robodoo r+