-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIX] ChartJs: Properly destroy chartJs object on component wrapper d…
…eletion How to reproduce: - Make a chartjs chart (line/bar/pie) - Mousedown on a datapoint/bar/part of the pie - move your mouse - mouseup (lift your finger) while still moving your mouse -> crash We were not properly destroying the chart js item and their linked eventListeners persisted. Specifically, the eventHandler of the tooltip plugin would still try to handle the mousemove event while its internal state was partially invalidated. closes #4165 Task: 3777754 X-original-commit: 1a0254b Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
- Loading branch information
Showing
3 changed files
with
13 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters